Skip to content
This repository was archived by the owner on Sep 20, 2022. It is now read-only.

Conversation

@charlypoly
Copy link
Contributor

Closes #502

@charlypoly charlypoly requested a review from dimaMachina March 18, 2022 14:52
@charlypoly charlypoly self-assigned this Mar 18, 2022
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

🦋 Changeset detected

Latest commit: 1439e8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guild-docs/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/the-guild-docs/QNJp5wboka1Nvb7Q7KK8z8SKrrsd
✅ Preview: https://the-guild-docs-git-feat-mermaid-theguild.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 567.24 KB (🔴 +260.77 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 2.18 KB (🟡 +12 B) 569.42 KB
/_error 194 B (🟡 +1 B) 567.43 KB
/docs/[[...slug]] 9.79 KB (🟡 +51 B) 577.03 KB
/mdx_component 1.08 KB (🟡 +10 B) 568.32 KB
/mdx_page 9.65 KB (🟡 +47 B) 576.89 KB
/packages 4.89 KB (🟢 -1.08 KB) 572.13 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@charlypoly
Copy link
Contributor Author

@B2o5T I'm not sure which packages (besides the client) should I bump, could you help me on this? 🙏🏼

@@ -0,0 +1,6 @@
---
"guild-docs": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guild-docs is a cli package, you didn't changed it

@dimaMachina
Copy link
Contributor

dimaMachina commented Mar 23, 2022

@B2o5T I'm not sure which packages (besides the client) should I bump, could you help me on this? 🙏🏼

@charlypoly I think only @guild-docs/client

Copy link
Contributor

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @charlypoly 😍

@dimaMachina dimaMachina merged commit b0e6536 into mdx-v2 Mar 23, 2022
dimaMachina added a commit that referenced this pull request Mar 23, 2022
* start working on mdx-js v2 update

* fixes

* fix and update dependencies

* changeset

* remove remark-admonitions

* Update packages/mdx-remote/src/index.ts

Co-authored-by: Dimitri POSTOLOV <[email protected]>

* Update packages/mdx-remote/src/format-mdx-error.ts

Co-authored-by: Dimitri POSTOLOV <[email protected]>

* refactor dev scripts

* Fix config, config types & add esmExternals by default

* add mdx-remote to root dev script

* Set react-use as peer dependency

* feat(client): add support for `mermaid-js` (#521)

* feat(client): add support for `mermaid-js`

Closes #502

* Create flat-bikes-attack.md

* Update .changeset/flat-bikes-attack.md

Co-authored-by: Saihajpreet Singh <[email protected]>

* some fixes

Co-authored-by: Saihajpreet Singh <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>

* some fixes

Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Charly POLY <[email protected]>
Co-authored-by: Charly POLY <[email protected]>
Co-authored-by: Saihajpreet Singh <[email protected]>
@saihaj saihaj deleted the feat/mermaid branch July 28, 2022 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants