mdx-js v2 update #473
mdx-js v2 update #473
Conversation
🦋 Changeset detectedLatest commit: e2ecc8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/the-guild-docs/2oemtF1Wp9kYBHtYMSiQ8Rp1BLom |
|
The latest changes of this PR are available as alpha in npm (based on the declared |
|
@B2o5T I managed to fix most of the errors except remark-admonitions https://github.com/elviswolcott/remark-admonitions, which stopped being maintained long ago, but graphql-codegen uses it a lot, that should be the only breaking thing by now (other than requiring Next.js v12) |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
|
||
| import { css, Global } from '@emotion/react'; | ||
| import RouterImport from 'next/router'; | ||
| import RouterImport from 'next/router.js'; |
There was a problem hiding this comment.
why it's necessary? and other cases with index.js
There was a problem hiding this comment.
this is part of esm, it's not new
There was a problem hiding this comment.
Next.js doesn't have explicit package exports, which means that deep imports need explicit extensions, it's just how it works
There was a problem hiding this comment.
test it yourself, remove the extensions, rebuild, and run node scripts/test-esm.mjs
There was a problem hiding this comment.
Amazing work @PabloSzx, I approve and wrote some review changes.
Before we merge this we need to discuss what we'll do with remark-admonitions. cc @dotansimha
Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: Dimitri POSTOLOV <[email protected]>
|
@B2o5T do we plan to merge this soon? The migration of the codegen doc can be quite easy by replacing |
* feat(client): add support for `mermaid-js` Closes #502 * Create flat-bikes-attack.md * Update .changeset/flat-bikes-attack.md Co-authored-by: Saihajpreet Singh <[email protected]> * some fixes Co-authored-by: Saihajpreet Singh <[email protected]> Co-authored-by: Dimitri POSTOLOV <[email protected]>
currently getting this error: syntax-tree/unist#63based on hashicorp/next-mdx-remote#211
I managed to fix all the errors except remark-admonitions https://github.com/elviswolcott/remark-admonitions, which stopped being maintained long ago, but graphql-codegen uses it a lot, that should be the only breaking thing by now (other than now requiring Next.js v12)
closes #465