Make serde dependency optional #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The information about the config file in the README need to be expanded... Can some one else work on this? |
|
@malbarbo This is great! In a minute am going to update this PR with a commit with a few naming tweaks, but this looks pretty much perfect to me. Please let me know if you think that my modifications look OK? |
- Rename the feature to "serialization" - Expand the commentary in README.md a bit - Add docstrings to the two `PersistentConfig::open()` methods - Single-line style in the `extern crate` directives
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=========================================
Coverage ? 41.46%
=========================================
Files ? 135
Lines ? 61128
Branches ? 0
=========================================
Hits ? 25344
Misses ? 35784
Partials ? 0
Continue to review full report at Codecov.
|
|
@pkgw It's look great to me! |
Mrmaxmeier
pushed a commit
to Mrmaxmeier/tectonic
that referenced
this pull request
Jul 29, 2020
fix osx build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
confile_filefeature that is enabled by default. Disabling the feature allow building for musl targets.