static builder on travis #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next step to fix #185 is to deploy the static build. But I don't known how to do it. |
|
Cool, thanks! Let's hold this until #259 converges. |
- Rename the feature to "serialization" - Expand the commentary in README.md a bit - Add docstrings to the two `PersistentConfig::open()` methods - Single-line style in the `extern crate` directives
When linking statically on musl targets, this function clashes with a symbol in OpenSSL. So just rename it.
- Don't bother with the Docker shell scripts, which were one-liners - docker/x86_musl => dist/docker/x86-alpine-linux-musl - The rename of AES_cbc_encrypt is now permanently applied - Run the test suite inside the static container - Add copyright/license headers - Move the pkg-config-rs patching script to the specific Docker directory - Add Cargo.toml note about tracking the correct version of pkg-config.rs
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=========================================
Coverage ? 41.47%
=========================================
Files ? 135
Lines ? 61169
Branches ? 0
=========================================
Hits ? 25371
Misses ? 35798
Partials ? 0
Continue to review full report at Codecov.
|
|
@pkgw It's look great to me! Thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #259