Skip to content

Conversation

@piotr-iohk
Copy link
Collaborator

@piotr-iohk piotr-iohk commented Oct 17, 2025

Description

This PR:

  • adds some accesibility identifiers for onboarding e2e tests. The ids match the native bitkit-android.
  • adjusts address turncating logic in AddressViewer such that it matches android (012f654)
  • updates e2e GH workflow such that it is started for each PR

Linked Issues/Tasks

synonymdev/bitkit-e2e-tests#35

Screenshot / Video

Insert relevant screenshot / recording

@piotr-iohk piotr-iohk self-assigned this Oct 17, 2025
@piotr-iohk piotr-iohk force-pushed the piotr/onboarding-test-ids branch from a2e002a to 012f654 Compare October 27, 2025 18:24
@piotr-iohk piotr-iohk changed the title Onboarding test ids Onboarding test updates Oct 27, 2025
@piotr-iohk piotr-iohk force-pushed the piotr/onboarding-test-ids branch 3 times, most recently from bd3fbf8 to 012f654 Compare October 28, 2025 08:46
@piotr-iohk piotr-iohk marked this pull request as ready for review October 28, 2025 15:55
@piotr-iohk piotr-iohk requested a review from Copilot October 28, 2025 16:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds accessibility identifiers for end-to-end testing automation and improves address truncation logic to match Android implementation.

  • Adds accessibility identifiers across onboarding, settings, and UI components to enable automated testing
  • Updates address truncation in AddressViewer to use SwiftUI's native .truncationMode(.middle) instead of custom logic
  • Updates e2e GitHub workflow to run on pull requests and implements retry logic for test stability

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Bitkit/Views/Wallets/Receive/QrArea.swift Adds accessibility identifiers to invoice and copy buttons
Bitkit/Views/Settings/MainSettings.swift Adds accessibility identifiers to all main settings navigation links
Bitkit/Views/Settings/Backup/BackupSettings.swift Adds accessibility identifiers to backup options and scroll view
Bitkit/Views/Settings/Advanced/AdvancedSettingsView.swift Adds accessibility identifiers to advanced settings navigation links
Bitkit/Views/Settings/Advanced/AddressViewer.swift Refactors address display to use native truncation instead of custom logic
Bitkit/Views/Onboarding/WalletRestoreSuccess.swift Adds accessibility identifier to get started button
Bitkit/Views/Onboarding/RestoreWalletView.swift Adds accessibility identifiers to restore wallet inputs and buttons
Bitkit/Views/Onboarding/OnboardingSlider.swift Adds accessibility identifiers to onboarding slides and buttons
Bitkit/Views/Onboarding/MultipleWalletsView.swift Adds accessibility identifier to understood button
Bitkit/Views/Onboarding/IntroView.swift Adds accessibility identifiers to intro navigation buttons
Bitkit/Views/Onboarding/CreateWalletWithPassphraseView.swift Adds accessibility identifiers to passphrase input and create button
Bitkit/Views/Onboarding/CreateWalletView.swift Adds accessibility identifiers to new/restore wallet buttons
Bitkit/Views/Backup/BackupMnemonic.swift Adds accessibility support for mnemonic display with proper labeling
Bitkit/Components/SeedTextField.swift Adds accessibility identifiers to seed word input fields
Bitkit/Components/QR.swift Adds accessibility support for QR code with content labels
Bitkit/Components/NavigationBar.swift Adds accessibility identifier to header menu button
Bitkit/Components/Home/SuggestionsCard.swift Adds accessibility identifier to suggestion dismiss button
Bitkit/Components/Home/Suggestions.swift Adds accessibility identifiers to suggestion cards and container
Bitkit/Components/Header.swift Adds accessibility identifier to header menu button
Bitkit/Components/EmptyStateView.swift Adds accessibility identifier to onboarding close button
Bitkit/Components/DrawerView.swift Adds accessibility identifiers to drawer menu items
.github/workflows/e2e-tests.yml Updates workflow to run on PRs with retry logic and dynamic branch selection

@piotr-iohk piotr-iohk requested review from jvsena42 and pwltr October 28, 2025 16:43
@piotr-iohk piotr-iohk merged commit de861d2 into master Oct 28, 2025
5 checks passed
@piotr-iohk piotr-iohk deleted the piotr/onboarding-test-ids branch October 28, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants