-
Notifications
You must be signed in to change notification settings - Fork 0
Onboarding test updates #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2e002a to
012f654
Compare
bd3fbf8 to
012f654
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds accessibility identifiers for end-to-end testing automation and improves address truncation logic to match Android implementation.
- Adds accessibility identifiers across onboarding, settings, and UI components to enable automated testing
- Updates address truncation in AddressViewer to use SwiftUI's native
.truncationMode(.middle)instead of custom logic - Updates e2e GitHub workflow to run on pull requests and implements retry logic for test stability
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Bitkit/Views/Wallets/Receive/QrArea.swift | Adds accessibility identifiers to invoice and copy buttons |
| Bitkit/Views/Settings/MainSettings.swift | Adds accessibility identifiers to all main settings navigation links |
| Bitkit/Views/Settings/Backup/BackupSettings.swift | Adds accessibility identifiers to backup options and scroll view |
| Bitkit/Views/Settings/Advanced/AdvancedSettingsView.swift | Adds accessibility identifiers to advanced settings navigation links |
| Bitkit/Views/Settings/Advanced/AddressViewer.swift | Refactors address display to use native truncation instead of custom logic |
| Bitkit/Views/Onboarding/WalletRestoreSuccess.swift | Adds accessibility identifier to get started button |
| Bitkit/Views/Onboarding/RestoreWalletView.swift | Adds accessibility identifiers to restore wallet inputs and buttons |
| Bitkit/Views/Onboarding/OnboardingSlider.swift | Adds accessibility identifiers to onboarding slides and buttons |
| Bitkit/Views/Onboarding/MultipleWalletsView.swift | Adds accessibility identifier to understood button |
| Bitkit/Views/Onboarding/IntroView.swift | Adds accessibility identifiers to intro navigation buttons |
| Bitkit/Views/Onboarding/CreateWalletWithPassphraseView.swift | Adds accessibility identifiers to passphrase input and create button |
| Bitkit/Views/Onboarding/CreateWalletView.swift | Adds accessibility identifiers to new/restore wallet buttons |
| Bitkit/Views/Backup/BackupMnemonic.swift | Adds accessibility support for mnemonic display with proper labeling |
| Bitkit/Components/SeedTextField.swift | Adds accessibility identifiers to seed word input fields |
| Bitkit/Components/QR.swift | Adds accessibility support for QR code with content labels |
| Bitkit/Components/NavigationBar.swift | Adds accessibility identifier to header menu button |
| Bitkit/Components/Home/SuggestionsCard.swift | Adds accessibility identifier to suggestion dismiss button |
| Bitkit/Components/Home/Suggestions.swift | Adds accessibility identifiers to suggestion cards and container |
| Bitkit/Components/Header.swift | Adds accessibility identifier to header menu button |
| Bitkit/Components/EmptyStateView.swift | Adds accessibility identifier to onboarding close button |
| Bitkit/Components/DrawerView.swift | Adds accessibility identifiers to drawer menu items |
| .github/workflows/e2e-tests.yml | Updates workflow to run on PRs with retry logic and dynamic branch selection |
pwltr
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Linked Issues/Tasks
synonymdev/bitkit-e2e-tests#35
Screenshot / Video
Insert relevant screenshot / recording