Onboarding on iOS #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds iOS support to the end-to-end test suite's onboarding flow. The existing test code was Android-only, and these changes introduce platform-specific handling to enable tests to run successfully on iOS simulators.
- Platform-specific UI interactions (checkboxes, keyboard confirmation, element selection)
- iOS simulator keychain reset improvements with UDID detection
- iOS-specific text input via pasteboard for seed phrase entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wdio.conf.ts | Added Appium stability configuration for iOS WebDriverAgent |
| test/specs/onboarding.e2e.ts | Added platform-specific logic for onboarding flow differences between iOS and Android |
| test/helpers/setup.ts | Enhanced iOS simulator keychain reset to use specific UDID instead of relying on booted simulator |
| test/helpers/actions.ts | Added iOS-specific helper functions and updated element selectors to support buttons, removed iOS notification alert handling, added update sheet dismissal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust onboarding to support iOS.