Skip to content

Add support for Symfony 8 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Add support for Symfony 8 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,38 @@ on:

jobs:
tests:
name: "Tests ${{ matrix.php-version }} deps ${{ matrix.dependency-versions }}"
runs-on: ubuntu-22.04

strategy:
fail-fast: false
matrix:
# normal, highest, non-dev installs
php-version: ['8.1', '8.2', '8.3', '8.4']
dependency-versions: ['highest']
dependency-version: [ 'highest' ]
symfony-version: [ '' ]
minimum-stability: ['stable']
include:
# testing lowest PHP version with lowest dependencies
- php-version: '8.1'
dependency-versions: 'lowest'
# dev packages (probably not needed to have multiple such jobs)
- minimum-stability: 'dev'
php-version: '8.4'
# lowest deps
- php-version: '8.1'
dependency-version: 'lowest'
# LTS version of Symfony
- php-version: '8.1'
symfony-version: '6.4.*'
# Explicit Symfony versions
- php-version: '8.1'
symfony-version: '5.4'
- php-version: '8.1'
symfony-version: '6.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't waste resources on EOL versions

Copy link
Member Author

@Kocal Kocal Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specified 6.2 and 7.0 because the Bundle support these versions. I also tend to not really care about unmaintained versions, but is it fine here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's about time to drop support for unmaintained Symfony releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally fine with that, but I was thinking doing that in a second PR, and then release WebpackEncoreBundle 3.0

- php-version: '8.2'
symfony-version: '7.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here but we can use 7.3 instead

- php-version: '8.4'
symfony-version: '8.0.x-dev' # TODO: change to '8.0' when Symfony 8.0 is released
minimum-stability: 'dev' # TODO: remove when Symfony 8.0 is released

env:
SYMFONY_REQUIRE: ${{ matrix.symfony-version || '>=5.4' }}

steps:
- name: "Checkout code"
Expand All @@ -31,20 +50,20 @@ jobs:
with:
coverage: "none"
php-version: "${{ matrix.php-version }}"
tools: flex

- name: Allow Flex Plugin
run: |
composer global config --no-plugins allow-plugins.symfony/flex true
run: composer global config --no-plugins allow-plugins.symfony/flex true

- name: Install Global Dependencies
run: |
composer global require --no-progress --no-scripts --no-plugins symfony/flex @dev
- name: Configure Composer minimum stability
run: composer config minimum-stability ${{ matrix.minimum-stability || 'stable' }} --ansi

- name: "Composer install"
uses: "ramsey/composer-install@v2"
with:
dependency-versions: "${{ matrix.dependency-versions }}"
dependency-versions: "${{ matrix.dependency-version }}"
composer-options: "--prefer-dist --no-progress"
custom-cache-suffix: "min-stability=${{ matrix.minimum-stability || 'stable' }}"

- name: Run tests
run: ./vendor/bin/simple-phpunit
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v2.3.0

- #248 Add support for Symfony 8 (@Kocal)

## v2.2.0

- #236 Allow entrypoints.json to be hosted remotely (@rlvdx & @Kocal)
Expand Down
18 changes: 9 additions & 9 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@
],
"require": {
"php": ">=8.1.0",
"symfony/asset": "^5.4 || ^6.2 || ^7.0",
"symfony/config": "^5.4 || ^6.2 || ^7.0",
"symfony/dependency-injection": "^5.4 || ^6.2 || ^7.0",
"symfony/http-kernel": "^5.4 || ^6.2 || ^7.0",
"symfony/asset": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/config": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/dependency-injection": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/http-kernel": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/service-contracts": "^1.1.9 || ^2.1.3 || ^3.0"
},
"require-dev": {
"symfony/framework-bundle": "^5.4 || ^6.2 || ^7.0",
"symfony/http-client": "^5.4 || ^6.2 || ^7.0",
"symfony/phpunit-bridge": "^5.4 || ^6.2 || ^7.0",
"symfony/twig-bundle": "^5.4 || ^6.2 || ^7.0",
"symfony/web-link": "^5.4 || ^6.2 || ^7.0"
"symfony/framework-bundle": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/http-client": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/phpunit-bridge": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/twig-bundle": "^5.4 || ^6.2 || ^7.0 || ^8.0",
"symfony/web-link": "^5.4 || ^6.2 || ^7.0 || ^8.0"
},
"minimum-stability": "dev",
"autoload": {
Expand Down
Loading