Add support for Symfony 8 #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
added
Feature
|
We probably need to tweak the CI matrix a bit as we currently don't have a job running against Symfony 7 (the same was actually already true before for Symfony 6). |
This comment was marked as off-topic.
This comment was marked as off-topic.
Kocal
force-pushed
the
symfony-8-support
branch
3 times, most recently
from
d97591a to
4c006dc
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
xabbuh
reviewed
Aug 5, 2025
xabbuh
reviewed
Aug 5, 2025
xabbuh
reviewed
Aug 5, 2025
| - php-version: '8.1' | ||
| symfony-version: '5.4' | ||
| - php-version: '8.1' | ||
| symfony-version: '6.2' |
There was a problem hiding this comment.
I wouldn't waste resources on EOL versions
There was a problem hiding this comment.
I specified 6.2 and 7.0 because the Bundle support these versions. I also tend to not really care about unmaintained versions, but is it fine here?
There was a problem hiding this comment.
maybe it's about time to drop support for unmaintained Symfony releases
There was a problem hiding this comment.
I'm totally fine with that, but I was thinking doing that in a second PR, and then release WebpackEncoreBundle 3.0
xabbuh
reviewed
Aug 5, 2025
| - php-version: '8.1' | ||
| symfony-version: '6.2' | ||
| - php-version: '8.2' | ||
| symfony-version: '7.0' |
There was a problem hiding this comment.
same here but we can use 7.3 instead
Kocal
force-pushed
the
symfony-8-support
branch
4 times, most recently
from
7e16e26 to
5b14a24
Compare
Kocal
force-pushed
the
symfony-8-support
branch
from
5b14a24 to
4cc9ffd
Compare
Kocal
added a commit
to symfony/ux
that referenced
this pull request
Aug 6, 2025
…yImage][LiveComponent][Map][Notify][React][StimulusBundle][Svelte][Swup][TogglePassword][Toolkit][Translator][Turbo][TwigComponent][Typed][Vue] Add support for Symfony 8 (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Autocomplete][Chartjs][Cropperjs][Dropzone][Icons][LazyImage][LiveComponent][Map][Notify][React][StimulusBundle][Svelte][Swup][TogglePassword][Toolkit][Translator][Turbo][TwigComponent][Typed][Vue] Add support for Symfony 8 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> As suggested in symfony/webpack-encore-bundle#248, I added new jobs for testing explicit Symfony version. The Symfony 8.0.x-dev job is failing because it needs zenstruck/foundry#891, which is not possible to use because Foundry is not compatible with Symfony 8 yet (opened zenstruck/foundry#960) There is a lot of changes, but these are only small modifications (composer.json, CHANGELOG.md, and fixing method typings) I also updated the deprecated packages, that's fine, it makes things easier for us to handle Commits ------- 998de8d Add support for Symfony 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.