Skip to content

[CI] Add Fabbot as a GitHub Actions #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

[CI] Add Fabbot as a GitHub Actions #2955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/fabbot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Fabbot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Fabbot
name: CS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping Fabbot or even PHP CS since we have other coding styles checks (for JS)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I am also used to tell people "Please make Fabbot happy" :-)


on:
pull_request:

permissions:
contents: read

jobs:
call-fabbot:
name: Fabbot
uses: symfony-tools/fabbot/.github/workflows/fabbot.yml@main
with:
package: Symfony UX
Copy link
Member

@nicolas-grekas nicolas-grekas Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package: Symfony UX this means @deprecated should all start with @deprecated since Symfony UX that's not the case at the moment, let's fix this also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we will need to fix this too, actually we have no conventions at all

Copy link
Member

@nicolas-grekas nicolas-grekas Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabbot should be fixed
can you fix the @deprecated in the same PR?
they should all start with @deprecated since Symfony UX X.y, etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will fix the deprecated annotations

check_license: true
2 changes: 1 addition & 1 deletion src/Autocomplete/src/Form/AutocompleteEntityTypeSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
*
* @internal
*
* @deprecated since UX 2.13
* @deprecated since Symfony UX 2.13
*/
final class AutocompleteEntityTypeSubscriber implements EventSubscriberInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Autocomplete/src/Form/ChoiceList/Loader/ExtraLazyChoiceLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* Loads choices on demand only.
*
* @deprecated since Autocomplete 2.23 and will be removed in 3.0, use `Symfony\Component\Form\ChoiceList\Loader\LazyChoiceLoader` instead.
* @deprecated since Symfony UX 2.23 and will be removed in 3.0, use `Symfony\Component\Form\ChoiceList\Loader\LazyChoiceLoader` instead.
*/
class ExtraLazyChoiceLoader implements ChoiceLoaderInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Autocomplete/src/Form/ParentEntityAutocompleteType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
/**
* All form types that want to expose autocomplete functionality should use this for its getParent().
*
* @deprecated since UX 2.13, use "Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType" instead
* @deprecated since Symfony UX 2.13, use "Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType" instead
*/
final class ParentEntityAutocompleteType extends AbstractType implements DataMapperInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/TwigComponent/src/CVA.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
*
* @experimental
*
* @deprecated since TwigComponent 2.20, use CVA from the "twig/html-extra:^3.12.0" package instead.
* @deprecated since Symfony UX 2.20, use CVA from the "twig/html-extra:^3.12.0" package instead.
*/
final class CVA
{
Expand Down
2 changes: 1 addition & 1 deletion src/TwigComponent/src/Event/PreCreateForRenderEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function getName(): string
}

/**
* @deprecated since 2.8, use getInputProps() instead.
* @deprecated since Symfony UX 2.8, use getInputProps() instead.
*/
public function getProps(): array
{
Expand Down
Loading