Skip to content

[CI] Add Fabbot as a GitHub Actions #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

[CI] Add Fabbot as a GitHub Actions #2955

merged 1 commit into from
Jul 29, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jul 29, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

refs:

Since the code formatting process if more transparent, maybe we will remove the job coding-style-php that manually execute PHP-CS-Fixer (we had many formatting issues in the past)

@carsonbot carsonbot added Bug Bug Fix Feature New Feature Status: Needs Review Needs to be reviewed labels Jul 29, 2025
@Kocal
Copy link
Member Author

Kocal commented Jul 29, 2025

@nicolas-grekas The step Check PR header is failing with error message syntax error near unexpected token |', I think that's because the presence of " character in the PR_BODY

Maybe something like:

PR_TITLE=$(cat <<EOF
${{ github.event.pull_request.title }}
EOF
)
PR_BODY=$(cat <<EOF
{{ github.event.pull_request.body }}
EOF
)

?

@Kocal Kocal removed Bug Bug Fix Feature New Feature labels Jul 29, 2025
name: Fabbot
uses: symfony-tools/fabbot/.github/workflows/fabbot.yml@main
with:
package: Symfony UX
Copy link
Member

@nicolas-grekas nicolas-grekas Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package: Symfony UX this means @deprecated should all start with @deprecated since Symfony UX that's not the case at the moment, let's fix this also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we will need to fix this too, actually we have no conventions at all

Copy link
Member

@nicolas-grekas nicolas-grekas Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabbot should be fixed
can you fix the @deprecated in the same PR?
they should all start with @deprecated since Symfony UX X.y, etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will fix the deprecated annotations

@@ -0,0 +1,15 @@
name: Fabbot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Fabbot
name: CS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping Fabbot or even PHP CS since we have other coding styles checks (for JS)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I am also used to tell people "Please make Fabbot happy" :-)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 29, 2025
@Kocal Kocal merged commit 0b2b031 into symfony:2.x Jul 29, 2025
23 of 25 checks passed
@Kocal Kocal deleted the fabbot branch July 29, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants