-
-
Notifications
You must be signed in to change notification settings - Fork 376
[CI] Add Fabbot as a GitHub Actions #2955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nicolas-grekas The step Maybe something like: PR_TITLE=$(cat <<EOF
${{ github.event.pull_request.title }}
EOF
)
PR_BODY=$(cat <<EOF
{{ github.event.pull_request.body }}
EOF
) ? |
name: Fabbot | ||
uses: symfony-tools/fabbot/.github/workflows/fabbot.yml@main | ||
with: | ||
package: Symfony UX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package: Symfony UX
this means @deprecated
should all start with @deprecated since Symfony UX
that's not the case at the moment, let's fix this also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we will need to fix this too, actually we have no conventions at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fabbot should be fixed
can you fix the @deprecated
in the same PR?
they should all start with @deprecated since Symfony UX X.y, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will fix the deprecated annotations
@@ -0,0 +1,15 @@ | |||
name: Fabbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Fabbot | |
name: CS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer keeping Fabbot
or even PHP CS
since we have other coding styles checks (for JS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I am also used to tell people "Please make Fabbot happy" :-)
refs:
Since the code formatting process if more transparent, maybe we will remove the job
coding-style-php
that manually execute PHP-CS-Fixer (we had many formatting issues in the past)