adds session object as input / output to some of the api functions in session recipe #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
porcellus
approved these changes
Aug 15, 2022
29 tasks
rishabhpoddar
added a commit
that referenced
this pull request
Sep 14, 2022
* feat(sessiongrants): define types and add some implementation for session grants * refactor(sessiongrants): implement interface related feedback * refactor(sesssiongrants): renamed to claims * refactor(sessionclaims): implementing review feedback + cleanup * feat(sessiongrants): updated claims interface & fixes * refactor(sessiongrants): updating the interface WIP * refactor: review feedback + merge updates * feat: implementing review feedback * feat(sessionclaims): implementing interface feedback + initial tests * feat(sessionclaims): add claim management funcs to session * feat(sessionclaims): remove separate session claims field from AT * fix(sessionclaims): add missing await to fix applyClaimBuilder * feat(sessionclaims): implementing review feedback * feat(sessionclaims): implementing review feedback * feat(sessionclaims): implementing review feedback * refactor(sessionclaims): review feedback * feat(sessionclaims): review changes + exporting missing functions * feat: review feedback * feat: clarifications/minor improvements + further testing * refactor: change getLastRefetchTime to return raw number instead of Date * feat(sessionclaims): review feedback * test(sessionclaims): add removeClaim and fetchAndSetClaim tests * refactor(sessionclaims): added debug log after session claims assertion * feat: move claim assertion out of getSession * feat: add isTrue and isFalse validators * feat: review feedback * feat: initial (untested) implementation for email verification claims * fix(sessionclaims): fix circular dep error * fix(sessionclaims): add missing initializer for bootstrap callback list * test(sessionclaims): remove test of deleted module * refactor(sessionclaims): renamed parameter to fit existing terminology * feat: review feedback (#350) * refactor(sessionclaims): further review feedback * test(sessionclaims): add tests for session handle methods + extend tests * refactor: rename removeFromPayload + fix value type of PrimitiveClaim * feat(sessionclaims): implement review feedback * refactor(sessionclaims): finished renaming EmailVerifiedClaim * feat(sessionclaims): implement review feedback * feat(sessionclaims): mark passwordless users as validated * fix(sessionclaims): add missing await * test(sessionclaims): remove unused test code * fix(sessionclaims): self-review fix * feat(sessionclaims): review feedback * feat(sessionclaims): review feedback (#352) * feat(sessionclaims): make validators return only promises * refactor(sessionclaims): check expiration first in primitive claims * refactor(sessionclaims): throw on duplicate claims added by recipes * test(sessionclaims): update tests for async validators * feat(sessionclaims): make getClaimValue non-throwing * feat(sessionclaims): adding claim validation functions to session recipe * feat(sessionclaims): implement review feedback * feat(sessionclaims): review feedback * test(sessionclaims): update tests (#356) * fix(sessionclaims): fix updating claims * feat(sessionclaims): make the email param optional in user facing emailverification methods * test(sessionclaims): update/fix tests * refactor(sessionclaims): removed unnecessary if + console log * feat(sessionclaims): remove console log * feat(sessionclaims): add roles claim and primitive array claim (#357) * feat(sessionclaims): add roles claim and primitive array claim to support * feat(sessionclaims): removed strictEquals * chore: update changelog (#358) * chore(sessionclaims): update changelog * chore: add update instruction to changelog * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Rishabh Poddar <[email protected]> * feat(sessionclaims): add request to default usercontext of verifySession (#361) * refactor to session recipe to remove extra assertClaims (#366) * refactor to session recipe to remove extra assertClaims * feat: review feedback + test fixing * test: updated test after the merge * feat: fix updateAccessTokenPayload param type Co-authored-by: Mihaly Lengyel <[email protected]> * Fixes to session grants base branch (#369) * fixes to emaildelivery import from emailverification reicpe * fixes issue with emailverification function TS * fixes typo in SMTP service * feat(sessionclaims): review feedback (#370) * feat(sessionclaims): review feedback * refactor: added missing id override to boolean claim validators * adds session object as input / output to some of the api functions in session recipe (#371) * fix: fix the returned status of revokeEmailVerificationTokens for pwless users (#372) * fix: fix the returned status of revokeEmailVerificationTokens for pwless users * test: test revokeEmailVerificationTokens when getEmailForUserId returns an error * Signinup function cleanup (#373) * removes unnecessary param in signInUp function * fixes tests * fixes more tests * fix: passing changelog in emailverification api + added migration for passwordless-emailverification into changelog * feat: refetch email verified claim based on maxAgeInSeconds (5 min default) (#378) * fix: check and throw if sessionExpiredStatusCode == invalidClaimStatusCode * chore: update changelog to mention changed integration and role guides * fix: fix type issues from review comments * fix: make userContext non-optional in recipe interface method inputs * chore: updated supported fdi version * test: fix tests Co-authored-by: Mihaly Lengyel <[email protected]> Co-authored-by: Rishabh Poddar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Just like how we changed the email verification API interface to accept session as input to the some of its functions, we should make similar changes to other APIs as well that "require" a session. So I have changed the signOut API in the session recipe to have this.
I also returned the session object from the refresh session API, since we are following a pattern that the API interface functions should return everything that it creates in it.