Skip to content

refactor to session recipe to remove extra assertClaims #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2022
Merged

refactor to session recipe to remove extra assertClaims #366

merged 5 commits into from
Aug 8, 2022

Conversation

@rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Aug 5, 2022

Summary of change

  • Removes the need to have assertClaim as a recipe function since it was doing almost the same thing as a different recipe function - validateClaims
  • Renames validateClaimsForSessionHandle to validateClaims since validateClaims is now being called from session class as well.
  • Makes the session class assertClaim use the recipe implementation function - just like the other functions in the class.

@rishabhpoddar rishabhpoddar requested a review from porcellus August 5, 2022 13:04
@rishabhpoddar rishabhpoddar mentioned this pull request Aug 5, 2022
Merged
31 tasks
@porcellus porcellus mentioned this pull request Aug 5, 2022
Merged
10 tasks
@rishabhpoddar rishabhpoddar merged commit bc1aa0d into session_grants Aug 8, 2022
@rishabhpoddar rishabhpoddar deleted the asession_claim_assert_claim_refactor branch August 8, 2022 07:38
@rishabhpoddar rishabhpoddar mentioned this pull request Aug 21, 2022
Merged
29 tasks
rishabhpoddar added a commit that referenced this pull request Sep 14, 2022
@porcellus @rishabhpoddar
feat(sessiongrants): add support for session grants (#278)
a8024d3 
* feat(sessiongrants): define types and add some implementation for session grants

* refactor(sessiongrants): implement interface related feedback

* refactor(sesssiongrants): renamed to claims

* refactor(sessionclaims): implementing review feedback + cleanup

* feat(sessiongrants): updated claims interface & fixes

* refactor(sessiongrants): updating the interface WIP

* refactor: review feedback + merge updates

* feat: implementing review feedback

* feat(sessionclaims): implementing interface feedback + initial tests

* feat(sessionclaims): add claim management funcs to session

* feat(sessionclaims): remove separate session claims field from AT

* fix(sessionclaims): add missing await to fix applyClaimBuilder

* feat(sessionclaims): implementing review feedback

* feat(sessionclaims): implementing review feedback

* feat(sessionclaims): implementing review feedback

* refactor(sessionclaims): review feedback

* feat(sessionclaims): review changes + exporting missing functions

* feat: review feedback

* feat: clarifications/minor improvements + further testing

* refactor: change getLastRefetchTime to return raw number instead of Date

* feat(sessionclaims): review feedback

* test(sessionclaims): add removeClaim and fetchAndSetClaim tests

* refactor(sessionclaims): added debug log after session claims assertion

* feat: move claim assertion out of getSession

* feat: add isTrue and isFalse validators

* feat: review feedback

* feat: initial (untested) implementation for email verification claims

* fix(sessionclaims): fix circular dep error

* fix(sessionclaims): add missing initializer for bootstrap callback list

* test(sessionclaims): remove test of deleted module

* refactor(sessionclaims): renamed parameter to fit existing terminology

* feat: review feedback (#350)

* refactor(sessionclaims): further review feedback

* test(sessionclaims): add tests for session handle methods + extend tests

* refactor: rename removeFromPayload + fix value type of PrimitiveClaim

* feat(sessionclaims): implement review feedback

* refactor(sessionclaims): finished renaming EmailVerifiedClaim

* feat(sessionclaims): implement review feedback

* feat(sessionclaims): mark passwordless users as validated

* fix(sessionclaims): add missing await

* test(sessionclaims): remove unused test code

* fix(sessionclaims): self-review fix

* feat(sessionclaims): review feedback

* feat(sessionclaims): review feedback (#352)

* feat(sessionclaims): make validators return only promises

* refactor(sessionclaims): check expiration first in primitive claims

* refactor(sessionclaims): throw on duplicate claims added by recipes

* test(sessionclaims): update tests for async validators

* feat(sessionclaims): make getClaimValue non-throwing

* feat(sessionclaims): adding claim validation functions to session recipe

* feat(sessionclaims): implement review feedback

* feat(sessionclaims): review feedback

* test(sessionclaims): update tests (#356)

* fix(sessionclaims): fix updating claims

* feat(sessionclaims): make the email param optional in user facing emailverification methods

* test(sessionclaims): update/fix tests

* refactor(sessionclaims): removed unnecessary if + console log

* feat(sessionclaims): remove console log

* feat(sessionclaims): add roles claim and primitive array claim (#357)

* feat(sessionclaims): add roles claim and primitive array claim to support

* feat(sessionclaims): removed strictEquals

* chore: update changelog (#358)

* chore(sessionclaims): update changelog

* chore: add update instruction to changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Rishabh Poddar <[email protected]>

* feat(sessionclaims): add request to default usercontext of verifySession (#361)

* refactor to session recipe to remove extra assertClaims (#366)

* refactor to session recipe to remove extra assertClaims

* feat: review feedback + test fixing

* test: updated test after the merge

* feat: fix updateAccessTokenPayload param type

Co-authored-by: Mihaly Lengyel <[email protected]>

* Fixes to session grants base branch (#369)

* fixes to emaildelivery import from emailverification reicpe

* fixes issue with emailverification function TS

* fixes typo in SMTP service

* feat(sessionclaims): review feedback (#370)

* feat(sessionclaims): review feedback

* refactor: added missing id override to boolean claim validators

* adds session object as input / output to some of the api functions in session recipe (#371)

* fix: fix the returned status of revokeEmailVerificationTokens for pwless users (#372)

* fix: fix the returned status of revokeEmailVerificationTokens for pwless users

* test: test revokeEmailVerificationTokens when getEmailForUserId returns an error

* Signinup function cleanup (#373)

* removes unnecessary param in signInUp function

* fixes tests

* fixes more tests

* fix: passing changelog in emailverification api + added migration for passwordless-emailverification into changelog

* feat: refetch email verified claim based on maxAgeInSeconds (5 min default) (#378)

* fix: check and throw if sessionExpiredStatusCode == invalidClaimStatusCode

* chore: update changelog to mention changed integration and role guides

* fix: fix type issues from review comments

* fix: make userContext non-optional in recipe interface method inputs

* chore: updated supported fdi version

* test: fix tests

Co-authored-by: Mihaly Lengyel <[email protected]>
Co-authored-by: Rishabh Poddar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porcellus porcellus porcellus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishabhpoddar @porcellus