Skip to content

fix serializesAsBase, deprecate borrowSerialization #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

fix serializesAsBase, deprecate borrowSerialization #103

merged 1 commit into from
Aug 28, 2025

Conversation

@arnetheduck
Copy link
Member

@arnetheduck arnetheduck commented Aug 19, 2025

  • add top-level mixin for readValue to actually be found
  • use in-place reader which potentially can be more efficient
  • support reader/writer-only types
  • deprecate the other forms of serialization borrowing to discourage their global namespace pollution

@arnetheduck arnetheduck marked this pull request as draft August 19, 2025 21:27
@arnetheduck arnetheduck marked this pull request as ready for review August 26, 2025 05:21
@arnetheduck
fix serializesAsBase, deprecate borrowSerialization
996b886 
* add top-level mixin for `readValue` to actually be found
* use in-place reader which potentially can be more efficient
* support reader/writer-only types
* deprecate the other forms of serialization borrowing to discourage
their global namespace pollution
arnetheduck added a commit to status-im/nimbus-eth2 that referenced this pull request Aug 27, 2025
@arnetheduck
bump: *-serialization
9a18d67 
* status-im/nim-confutils#111
* status-im/nim-json-rpc#243
* status-im/nim-json-serialization#128
* status-im/nim-serialization#103
* status-im/nim-toml-serialization#93
@arnetheduck arnetheduck mentioned this pull request Aug 27, 2025
Merged
arnetheduck added a commit to status-im/nimbus-eth2 that referenced this pull request Aug 27, 2025
@arnetheduck
bump: *-serialization
a66b3dd 
* status-im/nim-confutils#111
* status-im/nim-json-rpc#243
* status-im/nim-json-serialization#128
* status-im/nim-serialization#103
* status-im/nim-toml-serialization#93
arnetheduck added a commit to status-im/nimbus-eth1 that referenced this pull request Aug 27, 2025
@arnetheduck
bump: *-serialization
ae3aa89 
* status-im/nim-confutils#111
* status-im/nim-json-rpc#243
* status-im/nim-json-serialization#128
* status-im/nim-serialization#103
* status-im/nim-toml-serialization#93
@arnetheduck arnetheduck mentioned this pull request Aug 27, 2025
Merged
arnetheduck added a commit to status-im/nimbus-eth1 that referenced this pull request Aug 27, 2025
@arnetheduck
bump: *-serialization
95398d5 
* status-im/nim-confutils#111
* status-im/nim-json-rpc#243
* status-im/nim-json-serialization#128
* status-im/nim-serialization#103
* status-im/nim-toml-serialization#93
@arnetheduck arnetheduck merged commit 73d6108 into master Aug 28, 2025
26 checks passed
@arnetheduck arnetheduck deleted the serializes-as-base branch August 28, 2025 09:49
arnetheduck added a commit to status-im/nimbus-eth2 that referenced this pull request Aug 28, 2025
@arnetheduck
bump: *-serialization (#7421)
19d7529 
* status-im/nim-confutils#111
* status-im/nim-json-rpc#243
* status-im/nim-json-serialization#128
* status-im/nim-serialization#103
* status-im/nim-toml-serialization#93
arnetheduck added a commit to status-im/nimbus-eth1 that referenced this pull request Aug 28, 2025
@arnetheduck
bump: *-serialization (#3597)
b9e01e2 
* status-im/nim-confutils#111
* status-im/nim-json-rpc#243
* status-im/nim-json-serialization#128
* status-im/nim-serialization#103
* status-im/nim-toml-serialization#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arnetheduck