move chronos integration to its own module #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason std/net should depend on chronos - this is a minor backwards-compatibility break in that std/net will no longer export chronos writers.
arnetheduck
added a commit
to status-im/nim-json-rpc
that referenced
this pull request
Aug 19, 2025
avoids messy upgrades where serialization suddenly fails
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Aug 27, 2025
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Aug 27, 2025
arnetheduck
added a commit
to status-im/nimbus-eth1
that referenced
this pull request
Aug 27, 2025
arnetheduck
added a commit
to status-im/nimbus-eth1
that referenced
this pull request
Aug 27, 2025
arnetheduck
added a commit
to status-im/nim-json-rpc
that referenced
this pull request
Aug 28, 2025
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Aug 28, 2025
arnetheduck
added a commit
to status-im/nimbus-eth1
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason std/net should depend on chronos - to provide backwards-compatibility, the chronos writers are re-exported when
json_serializationis available.Also add std/uri based on its toml counterpart