Skip to content

Conversation

@fdefelici
Copy link
Contributor

@fdefelici fdefelici commented Sep 10, 2025

Description

This is the last PR related to the RPC roll out in BitcoinRegtestController

In this PR, has been:

  • migrated BitcoinRPCRequest::list_unspent (now named BitcoinRegtestController::retrieve_utxo_set)
  • reviewed BitcoinRegtestController::get_all_utxo
  • reviewed BitcoinRegtestController::get_utxo
  • removed BitcoinRPCRequest entirely
  • moved/removed tests now belonging to BitcoinRegtestController
  • small cleaning/refactoring to improve code related to this change
  • increased tests coverage

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@fdefelici fdefelici added this to the 3.2.0.0.2 milestone Sep 10, 2025
@fdefelici fdefelici self-assigned this Sep 10, 2025
@fdefelici fdefelici moved this to Status: 💻 In Progress in Stacks Core Eng Sep 10, 2025
@fdefelici fdefelici linked an issue Sep 10, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 91.59292% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.39%. Comparing base (e864154) to head (0288c84).
⚠️ Report is 117 commits behind head on develop.

Files with missing lines Patch % Lines
...-node/src/burnchains/bitcoin_regtest_controller.rs 91.36% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6451      +/-   ##
===========================================
- Coverage    80.01%   79.39%   -0.62%     
===========================================
  Files          558      559       +1     
  Lines       343239   343679     +440     
===========================================
- Hits        274634   272878    -1756     
- Misses       68605    70801    +2196     
Files with missing lines Coverage Δ
...ode/src/burnchains/rpc/bitcoin_rpc_client/tests.rs 99.86% <100.00%> (+<0.01%) ⬆️
stacks-node/src/tests/mod.rs 72.26% <ø> (-0.94%) ⬇️
stacks-node/src/tests/neon_integrations.rs 32.13% <ø> (-19.33%) ⬇️
stackslib/src/chainstate/stacks/mod.rs 76.27% <100.00%> (-0.19%) ⬇️
...-node/src/burnchains/bitcoin_regtest_controller.rs 74.57% <91.36%> (+0.15%) ⬆️

... and 128 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e864154...0288c84. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fdefelici fdefelici marked this pull request as ready for review September 16, 2025 13:21
@fdefelici fdefelici requested review from a team as code owners September 16, 2025 13:21
@fdefelici fdefelici moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Sep 16, 2025
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Sep 17, 2025
@fdefelici fdefelici added this pull request to the merge queue Sep 17, 2025
Merged via the queue into stacks-network:develop with commit f0be205 Sep 17, 2025
1 of 2 checks passed
@fdefelici fdefelici deleted the refactor/btc-rpc-rollout-step7-6387 branch September 17, 2025 14:12
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Sep 17, 2025
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

refactor: roll out new RPC client in BitcoinRegtestController

3 participants