-
Notifications
You must be signed in to change notification settings - Fork 18
Allow developers to control the audio codecs #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
a817a45
added maxOpusPlaybackRate param
jpsantosbh 1d8c330
Merge branch 'main' into joao/opus_config
jpsantosbh ff9f615
testing
jpsantosbh 51ab08a
maxaveragebitrate
jpsantosbh 0670610
add PlaybackRate enum
jpsantosbh 950e8df
replace sdp with sdpTransform
jpsantosbh c65f62d
renaming parameters
jpsantosbh 0941f1d
hardening
jpsantosbh 94623fc
playground changes
jpsantosbh 20bcb3e
Merge branch 'main' into joao/opus_config
jpsantosbh c7a4220
Merge branch 'main' into joao/opus_config
jpsantosbh 07c55d2
Fix build
jpsantosbh db83282
cleanup
jpsantosbh 93d1fb0
manual prettier
jpsantosbh 78a1f78
Update internal/playground-js/src/fabric/index.js
jpsantosbh 81a1b4c
Update packages/js/src/fabric/WSClient.ts
jpsantosbh 8e924e0
flexible audio codec params
jpsantosbh 8d0f26e
Merge remote-tracking branch 'origin/main' into joao/opus_config
jpsantosbh 035d424
changeset
jpsantosbh dc0c11f
Atualizar o index.html
jpsantosbh 51c5eea
Atualizar o index.html
jpsantosbh 6e37d34
Atualizar o index.html
jpsantosbh 00b65d9
Update internal/playground-js/src/fabric/index.html
jpsantosbh aad67a7
UI fixes
jpsantosbh 41817e3
dependencies fix
jpsantosbh b8704ad
build fix
jpsantosbh 255f0cf
formating
jpsantosbh 37e545d
Update packages/webrtc/src/RTCPeer.ts
jpsantosbh a514e78
Update packages/js/src/fabric/interfaces/wsClient.ts
jpsantosbh 5f99076
fixes
jpsantosbh 5d5b474
fix
jpsantosbh 43d5abe
fix test
jpsantosbh eb67f33
test fix
jpsantosbh b54aa5a
fix sdpMediaOrderHack
jpsantosbh 4d49452
don't change the remote description
jpsantosbh 9b38f4a
Merge branch 'main' into joao/opus_config
jpsantosbh 7e5704c
cleanup
jpsantosbh 9e7335b
Update audio codec selection and input handling in the demo
jpsantosbh a1ec706
Merge branch 'main' into joao/opus_config
jpsantosbh 88534ea
testing
jpsantosbh eb4b374
testing
jpsantosbh aede240
Merge branch 'joao/opus_config' of github.com:signalwire/signalwire-j…
jpsantosbh 97afc46
testing
jpsantosbh d9f1610
revert
jpsantosbh bd5996f
Merge main into joao/opus_config and resolve conflicts
jpsantosbh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| '@signalwire/webrtc': minor | ||
| '@signalwire/js': minor | ||
| --- | ||
|
|
||
| Added dial params: | ||
|
|
||
| - audioCodecs | ||
|
|
||
| The new parameter allows developers to select the audio codec to use with the desired configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.