Allow developers to control the audio codecs #1190

jpsantosbh · 2025-03-11T13:24:30Z

Description

Added dial params:

audioCodecs

The new parameter allows developers to select the audio codec to use with the desired configuration

Replaced the `sdp` helper lib with `sdpTransform` and refactored some of the sdpHelpers code to benefit from `sdpTransform`

This allows a more semantic SDP manipulation now that we're exposing to the developer parameters to make changes on the SDP offers.

Type of change

Internal refactoring
Bug fix (bugfix - non-breaking)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

client.dial({
    to: document.getElementById('destination').value,
    rootElement: document.getElementById('rootElement'),
    video: true,
    audio: true,
    audioCodecs:[
     'opus:maxplaybackrate=8000;maxaveragebitrate=4000',
     'telephone-event:',
     'PCMU:'.
     'PCMA:'
    ]
  }})

changeset-bot · 2025-03-11T13:24:34Z

🦋 Changeset detected

Latest commit: bd5996f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@signalwire/webrtc	Minor
@signalwire/js	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

giavac · 2025-03-12T08:25:37Z

From https://datatracker.ietf.org/doc/html/rfc7587:

maxplaybackrate:  a hint about the maximum output sampling rate that
      the receiver is capable of rendering in Hz.  The decoder MUST be
      capable of decoding any audio bandwidth, but, due to hardware
      limitations, only signals up to the specified sampling rate can be
      played back.  Sending signals with higher audio bandwidth results
      in higher than necessary network usage and encoding complexity, so
      an encoder SHOULD NOT encode frequencies above the audio bandwidth
      specified by maxplaybackrate.  This parameter can take any value
      between 8000 and 48000, although commonly the value will match one
      of the Opus bandwidths (Table 1).  By default, the receiver is
      assumed to have no limitations, i.e., 48000.

 +--------------+----------------+-----------------+-----------------+
   | Abbreviation |      Name      | Audio Bandwidth |  Sampling Rate  |
   |              |                |       (Hz)      |       (Hz)      |
   +--------------+----------------+-----------------+-----------------+
   |      NB      |   Narrowband   |     0 - 4000    |       8000      |
   |              |                |                 |                 |
   |      MB      |   Mediumband   |     0 - 6000    |      12000      |
   |              |                |                 |                 |
   |      WB      |    Wideband    |     0 - 8000    |      16000      |
   |              |                |                 |                 |
   |     SWB      | Super-wideband |    0 - 12000    |      24000      |
   |              |                |                 |                 |
   |      FB      |    Fullband    |    0 - 20000    |      48000      |
   +--------------+----------------+-----------------+-----------------+

It may make sense to let the user pick one of those Sampling Rate values, rather than entering a number.

internal/playground-js/src/fabric/index.html

internal/playground-js/src/fabric/index.js

packages/webrtc/src/utils/helpers.ts

iAmmar7

Looks okay to me. 👍 I have a left a few questions.

I would give more weight to @giavac's review on this.

packages/webrtc/src/utils/sdpHelpers.ts

packages/webrtc/src/RTCPeer.ts

packages/webrtc/src/utils/helpers.ts

jpsantosbh · 2025-03-20T21:41:06Z

packages/webrtc/src/utils/sdpHelpers.test.ts

    const SDP_OPUS_STEREO =
-      'v=0\r\no=- 135160591336882782 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE audio video\r\na=msid-semantic: WMS 381b9efc-7cf5-45bb-8f39-c06558b288de\r\nm=audio 9 UDP/TLS/RTP/SAVPF 111 103 104 9 0 8 106 105 13 110 112 113 126\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:Y5Zy\r\na=ice-pwd:yQLVrXgG+irP0tgLLr4ZjQb5\r\na=ice-options:trickle\r\na=fingerprint:sha-256 45:ED:86:FB:EB:FE:21:20:62:C4:07:81:AA:B8:BC:87:60:CC:2B:54:CE:D5:F0:16:93:C4:61:23:28:59:DF:8B\r\na=setup:actpass\r\na=mid:audio\r\na=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level\r\na=sendrecv\r\na=rtcp-mux\r\na=rtpmap:111 opus/48000/2\r\na=rtcp-fb:111 transport-cc\r\na=fmtp:111 minptime=10;useinbandfec=1; stereo=1; sprop-stereo=1\r\na=rtpmap:103 ISAC/16000\r\na=rtpmap:104 ISAC/32000\r\na=rtpmap:9 G722/8000\r\na=rtpmap:0 PCMU/8000\r\na=rtpmap:8 PCMA/8000\r\na=rtpmap:106 CN/32000\r\na=rtpmap:105 CN/16000\r\na=rtpmap:13 CN/8000\r\na=rtpmap:110 telephone-event/48000\r\na=rtpmap:112 telephone-event/32000\r\na=rtpmap:113 telephone-event/16000\r\na=rtpmap:126 telephone-event/8000\r\na=ssrc:3652058873 cname:kufSZ8JnlRUuQVc2\r\na=ssrc:3652058873 msid:381b9efc-7cf5-45bb-8f39-c06558b288de 8841cbb1-90ba-4655-8784-60a185846706\r\na=ssrc:3652058873 mslabel:381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=ssrc:3652058873 label:8841cbb1-90ba-4655-8784-60a185846706\r\nm=video 9 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 102 122 127 121 125 107 108 109 124 120 123 119 114\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:Y5Zy\r\na=ice-pwd:yQLVrXgG+irP0tgLLr4ZjQb5\r\na=ice-options:trickle\r\na=fingerprint:sha-256 45:ED:86:FB:EB:FE:21:20:62:C4:07:81:AA:B8:BC:87:60:CC:2B:54:CE:D5:F0:16:93:C4:61:23:28:59:DF:8B\r\na=setup:actpass\r\na=mid:video\r\na=extmap:2 urn:ietf:params:rtp-hdrext:toffset\r\na=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time\r\na=extmap:4 urn:3gpp:video-orientation\r\na=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01\r\na=extmap:6 http://www.webrtc.org/experiments/rtp-hdrext/playout-delay\r\na=extmap:7 http://www.webrtc.org/experiments/rtp-hdrext/video-content-type\r\na=extmap:8 http://www.webrtc.org/experiments/rtp-hdrext/video-timing\r\na=extmap:10 http://tools.ietf.org/html/draft-ietf-avtext-framemarking-07\r\na=sendrecv\r\na=rtcp-mux\r\na=rtcp-rsize\r\na=rtpmap:96 VP8/90000\r\na=rtcp-fb:96 goog-remb\r\na=rtcp-fb:96 transport-cc\r\na=rtcp-fb:96 ccm fir\r\na=rtcp-fb:96 nack\r\na=rtcp-fb:96 nack pli\r\na=rtpmap:97 rtx/90000\r\na=fmtp:97 apt=96\r\na=rtpmap:98 VP9/90000\r\na=rtcp-fb:98 goog-remb\r\na=rtcp-fb:98 transport-cc\r\na=rtcp-fb:98 ccm fir\r\na=rtcp-fb:98 nack\r\na=rtcp-fb:98 nack pli\r\na=fmtp:98 profile-id=0\r\na=rtpmap:99 rtx/90000\r\na=fmtp:99 apt=98\r\na=rtpmap:100 H264/90000\r\na=rtcp-fb:100 goog-remb\r\na=rtcp-fb:100 transport-cc\r\na=rtcp-fb:100 ccm fir\r\na=rtcp-fb:100 nack\r\na=rtcp-fb:100 nack pli\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42001f\r\na=rtpmap:101 rtx/90000\r\na=fmtp:101 apt=100\r\na=rtpmap:102 H264/90000\r\na=rtcp-fb:102 goog-remb\r\na=rtcp-fb:102 transport-cc\r\na=rtcp-fb:102 ccm fir\r\na=rtcp-fb:102 nack\r\na=rtcp-fb:102 nack pli\r\na=fmtp:102 level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42001f\r\na=rtpmap:122 rtx/90000\r\na=fmtp:122 apt=102\r\na=rtpmap:127 H264/90000\r\na=rtcp-fb:127 goog-remb\r\na=rtcp-fb:127 transport-cc\r\na=rtcp-fb:127 ccm fir\r\na=rtcp-fb:127 nack\r\na=rtcp-fb:127 nack pli\r\na=fmtp:127 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\na=rtpmap:121 rtx/90000\r\na=fmtp:121 apt=127\r\na=rtpmap:125 H264/90000\r\na=rtcp-fb:125 goog-remb\r\na=rtcp-fb:125 transport-cc\r\na=rtcp-fb:125 ccm fir\r\na=rtcp-fb:125 nack\r\na=rtcp-fb:125 nack pli\r\na=fmtp:125 level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42e01f\r\na=rtpmap:107 rtx/90000\r\na=fmtp:107 apt=125\r\na=rtpmap:108 H264/90000\r\na=rtcp-fb:108 goog-remb\r\na=rtcp-fb:108 transport-cc\r\na=rtcp-fb:108 ccm fir\r\na=rtcp-fb:108 nack\r\na=rtcp-fb:108 nack pli\r\na=fmtp:108 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=4d0032\r\na=rtpmap:109 rtx/90000\r\na=fmtp:109 apt=108\r\na=rtpmap:124 H264/90000\r\na=rtcp-fb:124 goog-remb\r\na=rtcp-fb:124 transport-cc\r\na=rtcp-fb:124 ccm fir\r\na=rtcp-fb:124 nack\r\na=rtcp-fb:124 nack pli\r\na=fmtp:124 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=640032\r\na=rtpmap:120 rtx/90000\r\na=fmtp:120 apt=124\r\na=rtpmap:123 red/90000\r\na=rtpmap:119 rtx/90000\r\na=fmtp:119 apt=123\r\na=rtpmap:114 ulpfec/90000\r\na=ssrc-group:FID 1714381393 967654061\r\na=ssrc:1714381393 cname:kufSZ8JnlRUuQVc2\r\na=ssrc:1714381393 msid:381b9efc-7cf5-45bb-8f39-c06558b288de 99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc:1714381393 mslabel:381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=ssrc:1714381393 label:99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc:967654061 cname:kufSZ8JnlRUuQVc2\r\na=ssrc:967654061 msid:381b9efc-7cf5-45bb-8f39-c06558b288de 99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc:967654061 mslabel:381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=ssrc:967654061 label:99d2faa8-950d-40f7-ad80-16789c9b4faa\r\n'
-    const SDP_OPUS_NO_STEREO =
+      'v=0\r\no=- 135160591336882782 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=msid-semantic: WMS 381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=group:BUNDLE audio video\r\nm=audio 9 UDP/TLS/RTP/SAVPF 111 103 104 9 0 8 106 105 13 110 112 113 126\r\nc=IN IP4 0.0.0.0\r\na=rtpmap:111 opus/48000/2\r\na=rtpmap:103 ISAC/16000\r\na=rtpmap:104 ISAC/32000\r\na=rtpmap:9 G722/8000\r\na=rtpmap:0 PCMU/8000\r\na=rtpmap:8 PCMA/8000\r\na=rtpmap:106 CN/32000\r\na=rtpmap:105 CN/16000\r\na=rtpmap:13 CN/8000\r\na=rtpmap:110 telephone-event/48000\r\na=rtpmap:112 telephone-event/32000\r\na=rtpmap:113 telephone-event/16000\r\na=rtpmap:126 telephone-event/8000\r\na=fmtp:111 minptime=10;useinbandfec=1;stereo=1;sprop-stereo=1\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=rtcp-fb:111 transport-cc\r\na=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level\r\na=setup:actpass\r\na=mid:audio\r\na=sendrecv\r\na=ice-ufrag:Y5Zy\r\na=ice-pwd:yQLVrXgG+irP0tgLLr4ZjQb5\r\na=fingerprint:sha-256 45:ED:86:FB:EB:FE:21:20:62:C4:07:81:AA:B8:BC:87:60:CC:2B:54:CE:D5:F0:16:93:C4:61:23:28:59:DF:8B\r\na=ice-options:trickle\r\na=ssrc:3652058873 cname:kufSZ8JnlRUuQVc2\r\na=ssrc:3652058873 msid:381b9efc-7cf5-45bb-8f39-c06558b288de 8841cbb1-90ba-4655-8784-60a185846706\r\na=ssrc:3652058873 mslabel:381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=ssrc:3652058873 label:8841cbb1-90ba-4655-8784-60a185846706\r\na=rtcp-mux\r\nm=video 9 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 102 122 127 121 125 107 108 109 124 120 123 119 114\r\nc=IN IP4 0.0.0.0\r\na=rtpmap:96 VP8/90000\r\na=rtpmap:97 rtx/90000\r\na=rtpmap:98 VP9/90000\r\na=rtpmap:99 rtx/90000\r\na=rtpmap:100 H264/90000\r\na=rtpmap:101 rtx/90000\r\na=rtpmap:102 H264/90000\r\na=rtpmap:122 rtx/90000\r\na=rtpmap:127 H264/90000\r\na=rtpmap:121 rtx/90000\r\na=rtpmap:125 H264/90000\r\na=rtpmap:107 rtx/90000\r\na=rtpmap:108 H264/90000\r\na=rtpmap:109 rtx/90000\r\na=rtpmap:124 H264/90000\r\na=rtpmap:120 rtx/90000\r\na=rtpmap:123 red/90000\r\na=rtpmap:119 rtx/90000\r\na=rtpmap:114 ulpfec/90000\r\na=fmtp:97 apt=96\r\na=fmtp:98 profile-id=0\r\na=fmtp:99 apt=98\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42001f\r\na=fmtp:101 apt=100\r\na=fmtp:102 level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42001f\r\na=fmtp:122 apt=102\r\na=fmtp:127 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\na=fmtp:121 apt=127\r\na=fmtp:125 level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42e01f\r\na=fmtp:107 apt=125\r\na=fmtp:108 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=4d0032\r\na=fmtp:109 apt=108\r\na=fmtp:124 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=640032\r\na=fmtp:120 apt=124\r\na=fmtp:119 apt=123\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=rtcp-fb:96 goog-remb\r\na=rtcp-fb:96 transport-cc\r\na=rtcp-fb:96 ccm fir\r\na=rtcp-fb:96 nack\r\na=rtcp-fb:96 nack pli\r\na=rtcp-fb:98 goog-remb\r\na=rtcp-fb:98 transport-cc\r\na=rtcp-fb:98 ccm fir\r\na=rtcp-fb:98 nack\r\na=rtcp-fb:98 nack pli\r\na=rtcp-fb:100 goog-remb\r\na=rtcp-fb:100 transport-cc\r\na=rtcp-fb:100 ccm fir\r\na=rtcp-fb:100 nack\r\na=rtcp-fb:100 nack pli\r\na=rtcp-fb:102 goog-remb\r\na=rtcp-fb:102 transport-cc\r\na=rtcp-fb:102 ccm fir\r\na=rtcp-fb:102 nack\r\na=rtcp-fb:102 nack pli\r\na=rtcp-fb:127 goog-remb\r\na=rtcp-fb:127 transport-cc\r\na=rtcp-fb:127 ccm fir\r\na=rtcp-fb:127 nack\r\na=rtcp-fb:127 nack pli\r\na=rtcp-fb:125 goog-remb\r\na=rtcp-fb:125 transport-cc\r\na=rtcp-fb:125 ccm fir\r\na=rtcp-fb:125 nack\r\na=rtcp-fb:125 nack pli\r\na=rtcp-fb:108 goog-remb\r\na=rtcp-fb:108 transport-cc\r\na=rtcp-fb:108 ccm fir\r\na=rtcp-fb:108 nack\r\na=rtcp-fb:108 nack pli\r\na=rtcp-fb:124 goog-remb\r\na=rtcp-fb:124 transport-cc\r\na=rtcp-fb:124 ccm fir\r\na=rtcp-fb:124 nack\r\na=rtcp-fb:124 nack pli\r\na=extmap:2 urn:ietf:params:rtp-hdrext:toffset\r\na=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time\r\na=extmap:4 urn:3gpp:video-orientation\r\na=extmap:5 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01\r\na=extmap:6 http://www.webrtc.org/experiments/rtp-hdrext/playout-delay\r\na=extmap:7 http://www.webrtc.org/experiments/rtp-hdrext/video-content-type\r\na=extmap:8 http://www.webrtc.org/experiments/rtp-hdrext/video-timing\r\na=extmap:10 http://tools.ietf.org/html/draft-ietf-avtext-framemarking-07\r\na=setup:actpass\r\na=mid:video\r\na=sendrecv\r\na=ice-ufrag:Y5Zy\r\na=ice-pwd:yQLVrXgG+irP0tgLLr4ZjQb5\r\na=fingerprint:sha-256 45:ED:86:FB:EB:FE:21:20:62:C4:07:81:AA:B8:BC:87:60:CC:2B:54:CE:D5:F0:16:93:C4:61:23:28:59:DF:8B\r\na=ice-options:trickle\r\na=ssrc:1714381393 cname:kufSZ8JnlRUuQVc2\r\na=ssrc:1714381393 msid:381b9efc-7cf5-45bb-8f39-c06558b288de 99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc:1714381393 mslabel:381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=ssrc:1714381393 label:99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc:967654061 cname:kufSZ8JnlRUuQVc2\r\na=ssrc:967654061 msid:381b9efc-7cf5-45bb-8f39-c06558b288de 99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc:967654061 mslabel:381b9efc-7cf5-45bb-8f39-c06558b288de\r\na=ssrc:967654061 label:99d2faa8-950d-40f7-ad80-16789c9b4faa\r\na=ssrc-group:FID 1714381393 967654061\r\na=rtcp-mux\r\na=rtcp-rsize\r\n'


unfortunately, I had to update the SDP values.

One way to check if they still represent the test is to search for fmtp:111 in the opus tests and .local in the candidate's tests.

iAmmar7 · 2025-04-07T11:27:48Z

internal/playground-js/src/fabric/index.html

@@ -1,556 +1,338 @@
 <!DOCTYPE html>


Can you please run the prettier here? It seems to be a huge change, and I don't understand why. Probably because of some copy-paste.

Once the code is formatted; I might be able to help identify this problem if I see exact changes.

I'm not getting any prettier change on this file. Even after calling it manually on it.
Isn't that from the default styling of input type number?

Can you check if your prettier is configured to run on HTML files?

If I run prettier on this PR, almost the whole HTML file gets updated. Even you check the git diff in your branch; https://github.com/signalwire/signalwire-js/pull/1190/files#diff-754e5cd31ab8b2aa50d4c8bc70ffaf88866ca80db4a77a07a9dcbec89aaf27b0

Isn't that from the default styling of input type number?

Not sure what you mean here. I was highlighting the overflow issue only with this specific field.

Yes, what I'm saying is that that field is a number input. And maybe that is the reason why it's overflowing.

iAmmar7

Could you please run the prettier? It would be easier to review.

internal/playground-js/src/fabric/index.js

packages/core/src/types/utils.ts

iAmmar7 · 2025-04-07T12:15:27Z

packages/js/src/fabric/WSClient.ts


-  private buildOutboundCall(params: DialParams & { attach?: boolean }) {
-    const [pathname, query] = params.to.split('?')
+  private _validateDialParams(params: DialParams) {


Can we move this validator outside of the class? Since it seems to be a utility which does not need a class instance.

Maybe we move it here: packages/js/src/fabric/utils/validateCallDial.ts

Why a logic made exclusive for the class should be defined in another module?
this isn't a generic "utility" this is part of the dial() function just refactored to a function to add more semantics to the code.

Do you prefer this code to be inside the dial function?

packages/js/src/fabric/WSClient.ts

iAmmar7 · 2025-04-07T12:29:30Z

packages/webrtc/src/RTCPeer.ts

+  private _validateOptions() {
+    if (
+      this.options.useStereo === true &&
+      typeof this.options.audio === 'object' &&
+      (this.options.audio.channelCount ?? 2) != 2
+    ) {
+      throw new Error('Mismatch params: useStereo, audio.channelCount')
+    }
+  }


This seems to be a utility function not associated with the class instance. Should we move this to a utility file?

Also, should we throw an error from the constructor or when the actual API where this is used is called?

If you are expecting this to be passed by the developer, you will need to expose the useStereo on the DialParams.

This seems to be a utility function not associated with the class instance. Should we move this to a utility file?
Why did you have this impression? This utility is to validate the options passed in this class constructor according to the assumptions in this class implementation?

Also, should we throw an error from the constructor or when the actual API where this is used is called?
What actual API? The constructor is the one that receives the options params.

If you are expecting this to be passed by the developer, you will need to expose the useStereo on the DialParams.
I'm not making assumptions about who sets the useStero at this point.

Why did you have this impression?

The definition of the "utility function".

What actual API?

The actual API that creates this instance. For CF SDK, that would be the dial method.

All the above were questions: if you think that you don't need this, then we can leave it here as it is.

Ok, no need to expose the param to the developer that is not the goal of this PR.

I'm still confused about external "utility" idea...

This is the same case as above. This isn't a generic "utility" this is a "guard" for the assumptions/implementation defined in this class alone.

iAmmar7 · 2025-04-07T12:52:09Z

packages/webrtc/src/utils/sdpHelpers.ts

-  return sdp.replace(/\r\n/g, '\n').replace(/\r/g, '\n')
-}
+import { BaseConnectionOptions } from '../BaseConnection'
+import sdpTransform from 'sdp-transform'


Do you remember what was the API that was missing in the previous library "sdp" and it is available in the new library "sdp-transform"?

Asking because the old lib seems to be widely used in comparison to the new one: https://npmtrends.com/sdp-vs-sdp-transform

It isn't about a specific API, but about all APIs in general. sdp-transform is both more semantic and lighter at the same time.

I considered the adoption too, but if you check the starts, size, and the recent activity, you will see that sdp-trasform is a better option in general.

packages/webrtc/src/utils/helpers.ts

jpsantosbh · 2025-05-08T13:41:13Z

@iAmmar7 that is expected since PCMA doesn't support the same params as opus.
If you want to test PCMA you need to keep maxPlaybackRate and maxAvarageBitrate blank.

I tried this:

Screen.Recording.2025-05-08.at.2.10.51.PM.mov
Maybe you can list the codecs (with the correct strings) that are allowed, and I can help test all those manually.

:-( Only works with Firefox

iAmmar7 · 2025-05-27T17:11:41Z

@jpsantosbh, could you please check the CI? The Streaming test project is failing constantly in Production. I highlighted this before as well. This might be due to SDP changes, I am not sure.

jpsantosbh · 2025-05-27T20:24:22Z

@jpsantosbh, could you please check the CI? The Streaming test project is failing constantly in Production. I highlighted this before as well. This might be due to SDP changes, I am not sure.

@iAmmar7 I noticed that too.
The v2WebRTC is a known issue with the webhooks

And the streaming is unrelated to the SDP. The negotiations are successful

iAmmar7 · 2025-05-28T09:56:48Z

@iAmmar7 I noticed that too. The v2WebRTC is a known issue with the webhooks

And the streaming is unrelated to the SDP. The negotiations are successful !

So, do you know why the streaming test is failing? Maybe we need to ask RTC? It does not seem to be failing in the main branch though.
https://github.com/signalwire/signalwire-js/actions/workflows/browser-js-production.yml

jpsantosbh · 2025-05-28T13:29:58Z

Yeah, it fails locally for me to with a different error... but it's always an error with the streaming API not a negotiation issue.

iAmmar7 · 2025-05-28T13:56:51Z

Yeah, it fails locally for me to with a different error... but it's always an error with the streaming API not a negotiation issue.

Maybe it is not the negotiation but something else in this PR causing the issue. The last CI run on the main branch passed as well. You can see here: https://github.com/signalwire/signalwire-js/actions/runs/15299726881

There are 4 test files used in the Streaming project:

roomSessionStreamingAPI.spec.ts,
roomSessionStreaming.spec.ts
roomSessionMultipleStreams.spec.ts
roomSessionAutomaticStream.spec.ts

I would suggest trying to see how many of these are failing, and from there, we can debug failed tests one by one.

jpsantosbh · 2025-05-28T15:36:23Z

@iAmmar7

I tested locally using the same PRODUCTION_E2E_JS_SW_TEST_CONFIG CI values, and all streaming tests passed.

The 3 🔴 are safe to be ignored.
Let me know if all the requested changes were addressed or if I've missed anything.

iAmmar7 · 2025-05-28T16:27:44Z

The 3 🔴 are safe to be ignored.
Let me know if all the requested changes were addressed or if I've missed anything.

@jpsantosbh, thank you for all the changes. I don’t see any specific issues at the moment; however, the PR introduces significant changes to the WebRTC SDP-related utilities. That’s why I pointed it out; it's possible that the SDP changes are contributing to the Production test failures.

I'm not sure if we can safely ignore this without notifying the team about the consistent failures in the Production Streaming tests. Ignoring them now could lead to more complex debugging later on.

Please let me know if you need any support. I’d be happy to look into this together tomorrow.

jpsantosbh · 2025-05-28T16:32:37Z

Since the test passed locally, let's test if it will continue to fail after merging it to main.
If it continues to fail, I'll be happy to revert it as quickly as possible.

…s into joao/opus_config

iAmmar7 · 2025-06-12T09:53:22Z

Since the test passed locally, let's test if it will continue to fail after merging it to main. If it continues to fail, I'll be happy to revert it as quickly as possible.

Sure, up to you, you can resolve the conflicts and merge the PR.

- Resolved conflict in packages/core/src/utils/index.ts: Added new helper functions from main - Resolved conflict in packages/js/src/fabric/WSClient.ts: Updated buildOutboundCall to use ReattachParams - Resolved conflict in packages/webrtc/package.json: Updated @signalwire/core version but kept sdp-transform dependency - Updated package-lock.json

jpsantosbh · 2025-06-12T13:14:31Z

@iAmmar7 done!
The test you were making here #1233 didn't work?
Or do we want to try that before merging this?

iAmmar7 · 2025-06-12T13:28:16Z

@iAmmar7 done! The test you were making here #1233 didn't work?

The work in #1233 will take time. Something has changed in this PR, and it would require time to debug.

Or do we want to try that before merging this?

I don't merge any PR unless the PROD CI is green. Since you mentioned you want to test and would revert it back, that's why I said it's up to you.

This reverts commit ba71908.

added maxOpusPlaybackRate param

a817a45

jpsantosbh requested review from giavac and iAmmar7 March 11, 2025 13:24

jpsantosbh added 3 commits March 11, 2025 13:58

Merge branch 'main' into joao/opus_config

1d8c330

testing

ff9f615

maxaveragebitrate

51ab08a

giavac reviewed Mar 12, 2025

View reviewed changes

internal/playground-js/src/fabric/index.html Outdated Show resolved Hide resolved

giavac reviewed Mar 12, 2025

View reviewed changes

internal/playground-js/src/fabric/index.js Outdated Show resolved Hide resolved

giavac reviewed Mar 12, 2025

View reviewed changes

packages/webrtc/src/utils/helpers.ts Outdated Show resolved Hide resolved

add PlaybackRate enum

0670610

iAmmar7 reviewed Mar 12, 2025

View reviewed changes

replace sdp with sdpTransform

950e8df

jpsantosbh requested review from giavac and iAmmar7 March 20, 2025 21:37

jpsantosbh commented Mar 20, 2025

View reviewed changes

jpsantosbh added 5 commits March 20, 2025 18:47

renaming parameters

c65f62d

hardening

0941f1d

playground changes

94623fc

Merge branch 'main' into joao/opus_config

20bcb3e

Merge branch 'main' into joao/opus_config

c7a4220

jpsantosbh changed the title ~~WIP: added maxOpusPlaybackRate param~~ Added maxOpusPlaybackRate param Mar 25, 2025

Fix build

07c55d2

iAmmar7 reviewed Apr 7, 2025

View reviewed changes

packages/webrtc/src/utils/helpers.ts Outdated Show resolved Hide resolved

jpsantosbh added 2 commits April 8, 2025 15:06

cleanup

db83282

manual prettier

93d1fb0

jpsantosbh added 4 commits May 8, 2025 12:20

don't change the remote description

4d49452

Merge branch 'main' into joao/opus_config

9b38f4a

cleanup

7e5704c

Update audio codec selection and input handling in the demo

9e7335b

jpsantosbh requested review from briankwest and iAmmar7 May 26, 2025 16:59

jpsantosbh added 6 commits May 29, 2025 09:15

Merge branch 'main' into joao/opus_config

a1ec706

testing

88534ea

testing

eb4b374

Merge branch 'joao/opus_config' of github.com:signalwire/signalwire-j…

aede240

…s into joao/opus_config

testing

97afc46

revert

d9f1610

iAmmar7 approved these changes Jun 12, 2025

View reviewed changes

jpsantosbh merged commit ba71908 into main Jun 12, 2025
22 of 25 checks passed

jpsantosbh deleted the joao/opus_config branch June 12, 2025 13:59

jpsantosbh added a commit that referenced this pull request Jun 12, 2025

Revert "Allow developers to control the audio codecs (#1190)"

0f071a8

This reverts commit ba71908.

jpsantosbh added a commit that referenced this pull request Jun 12, 2025

Revert "Allow developers to control the audio codecs (#1190)" (#1239)

d4db4f3

Allow developers to control the audio codecs #1190

Allow developers to control the audio codecs #1190

Uh oh!

Conversation

jpsantosbh commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Added dial params:

Replaced the sdp helper lib with sdpTransform and refactored some of the sdpHelpers code to benefit from sdpTransform

Type of change

Code snippets

Uh oh!

changeset-bot bot commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

giavac commented Mar 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iAmmar7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iAmmar7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iAmmar7 Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jpsantosbh commented May 8, 2025

Uh oh!

iAmmar7 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpsantosbh commented May 27, 2025

Uh oh!

iAmmar7 commented May 28, 2025

Uh oh!

jpsantosbh commented May 28, 2025

Uh oh!

iAmmar7 commented May 28, 2025

Uh oh!

jpsantosbh commented Mar 11, 2025 •

edited

Loading

Replaced the `sdp` helper lib with `sdpTransform` and refactored some of the sdpHelpers code to benefit from `sdpTransform`

changeset-bot bot commented Mar 11, 2025 •

edited

Loading

iAmmar7 Apr 7, 2025 •

edited

Loading

iAmmar7 commented May 27, 2025 •

edited

Loading