Fix cleanup handler not called on background task expiration due to struct being captured before assignment #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…truct being captured before assignment
Contributor
|
Thanks @davisg123 ! Just merged. I'm gonna do another PR to remove taskID since it's no longer needed. Great catch! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were encountering this issue:
#54
The PR for the issue (#111) does prevent background crashes due to the upload task now completing on time
However, there is still an issue;
application.endBackgroundTaskis not called for tasks that do happen to expire in the backgroundUploadTaskInfoas a value type is captured bybeginBackgroundTaskbefore thecleanuphandler is assigned. You can see the issue by running version 1.0.6 where tasks expired often and set the breakpoint as seen in the attached screenshotMy fix is to no longer capture self in either closure.