Skip to content

Fix for app being terminated due to lingering bg tasks. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

Fix for app being terminated due to lingering bg tasks. #111

merged 1 commit into from
Jan 24, 2022

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Jan 24, 2022

Addresses issue #54

  • Cancels tasks if we run over rather than just suspending them.
  • Perform upload task cleanup as a task finishes rather than waiting for flush() to come around again.
  • Sets maximum connections to host to 2, rather than the default of 6 to ensure we're not filling up the entire network.

alanjcharles
alanjcharles approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bsneed bsneed merged commit ece2f24 into main Jan 24, 2022
@bsneed bsneed deleted the bsneed/url_timeout branch January 24, 2022 20:24
@davisg123 davisg123 mentioned this pull request Feb 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alanjcharles alanjcharles alanjcharles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsneed @alanjcharles