Return early from EffectTransform methods if no effect bits are set #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mzgoddard
suggested changes
Jul 18, 2019
Contributor
mzgoddard
left a comment
mzgoddard
left a comment
There was a problem hiding this comment.
We need to move the if test and return an initialized dst but otherwise this looks good to me.
Contributor
Author
|
@mzgoddard Good catch! |
Contributor
Author
|
Closing this PR in favor of a better one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR changes
EffectTransform'stransformColorandtransformPointmethods to check if any effect bits are set, and if not, return their inputs before doing anything else (e.g. getting uniforms, copying the input to the output).Reason for Changes
These functions are called inside tight loops, and optimizing them in this way appears to yield a ~25-30% performance improvement on "touching color" checks, according to this benchmark: