-
Notifications
You must be signed in to change notification settings - Fork 28
feat: fit_fmt and fix some formatting issues #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# error bar keyword arguments | ||
eb_kwargs = _filter_dict(kwargs, "eb_") | ||
eb_kwargs.setdefault("label", "Histogram Data") | ||
eb_kwargs.setdefault("fmt", "o") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree that the "o"
maker looks much better visually then the previous defaults.
tests/test_plot.py
Outdated
def pdf(x, a=1 / np.sqrt(2 * np.pi), x0=0, sigma=1, offset=0): | ||
return a * np.exp(-((x - x0) ** 2) / (2 * sigma ** 2)) + offset | ||
|
||
fig, ax = plt.subplots() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and now with me suggesting actual code and not a URL by accident. sigh.
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.62%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
I think this fixes #167.
Also closes #159.