Add support for different index bases in import_data #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For importing sparse tensor files without the assumed 1-based indexing
This was referenced Jun 9, 2023
Collaborator
|
@etphipp can you request a review from me when you are ready for this (or any) PR to be merged? (We may need to add this step to the CONTRIBUTING.md guide.) |
ntjohnson1
approved these changes
Jun 9, 2023
dmdunla
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #6 by adding an
index_baseoptional argument toimport_data()(which defaults to 1 to preserve current behavior). Also added a test that reads in a 0-based sptensor.