Skip to content

Use Box::new() instead of box syntax in library tests #97494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2022
Merged

Use Box::new() instead of box syntax in library tests #97494

merged 3 commits into from
May 30, 2022

Conversation

@est31
Copy link
Member

@est31 est31 commented May 28, 2022 •
edited
Loading

The tests inside library/* have no reason to use box syntax as they have 0 performance relevance. Therefore, we can safely remove them (instead of having to use alternatives like the one in #97293).

@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 28, 2022
@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2022
@est31 est31 force-pushed the remove_box_alloc_tests branch from b5ec8da to fc7b4c3 Compare May 28, 2022 21:31
@est31 est31 changed the title Use Box::new() instead of box syntax in alloc tests Use Box::new() instead of box syntax in library tests May 28, 2022
@est31 est31 changed the title Use Box::new() instead of box syntax in library tests [WIP] Use Box::new() instead of box syntax in library tests May 28, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@est31 est31 force-pushed the remove_box_alloc_tests branch from fc7b4c3 to a9dd595 Compare May 28, 2022 22:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@est31 est31 force-pushed the remove_box_alloc_tests branch from a9dd595 to cdb8e64 Compare May 28, 2022 23:50
@est31 est31 changed the title [WIP] Use Box::new() instead of box syntax in library tests Use Box::new() instead of box syntax in library tests May 28, 2022
@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 30, 2022

📌 Commit cdb8e64 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request May 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 30, 2022
@bors
Auto merge of rust-lang#97548 - Dylan-DPC:rollup-9x0va1d, r=Dylan-DPC
e810f75 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#97494 (Use Box::new() instead of box syntax in library tests)
 - rust-lang#97499 (Remove "sys isn't exported yet" phrase)
 - rust-lang#97504 (Ensure source file present when calculating max line number)
 - rust-lang#97519 (Re-add help_on_error for download-ci-llvm)
 - rust-lang#97531 (Note pattern mismatch coming from `for` loop desugaring)
 - rust-lang#97545 (Reword safety comments in core/hash/sip.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0ed320b into rust-lang:master May 30, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 30, 2022
@est31 est31 mentioned this pull request Jan 18, 2023
Merged
@est31 est31 mentioned this pull request Feb 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joshtriplett joshtriplett

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@est31 @rust-highfive @rust-log-analyzer @Dylan-DPC @bors @joshtriplett @rustbot