Skip to content

docs: add link explaining variance to NonNull docs #96674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

docs: add link explaining variance to NonNull docs #96674

merged 1 commit into from
May 10, 2022

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented May 3, 2022

No description provided.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 3, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2022
@thomcc
Copy link
Member

thomcc commented May 8, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented May 8, 2022

📌 Commit 6096cfb has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2022
@bors
Copy link
Collaborator

bors commented May 8, 2022

⌛ Testing commit 6096cfb with merge cb2c0697207a6122958b485f49fee57af40e1762...

@bors
Copy link
Collaborator

bors commented May 8, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@thomcc
Copy link
Member

thomcc commented May 9, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022
@matthiaskrgr
Copy link
Member

@bors rollup=always

@Dylan-DPC Dylan-DPC mentioned this pull request May 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2022
@bors
Auto merge of rust-lang#96891 - Dylan-DPC:rollup-echa4wg, r=Dylan-DPC
d53f1e8 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#93661 (Add missing rustc arg docs)
 - rust-lang#96674 (docs: add link explaining variance to NonNull docs)
 - rust-lang#96812 (Do not lint on explicit outlives requirements from external macros.)
 - rust-lang#96823 (Properly fix rust-lang#96638)
 - rust-lang#96872 (make sure ScalarPair enums have ScalarPair variants; add some layout sanity checks)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5c273b into rust-lang:master May 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bstrie @rust-highfive @thomcc @bors @rust-log-analyzer @matthiaskrgr @rustbot