Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 4, 2022

Add documentation for recently added rustc args

-C symbol-mangling-version was stabilized in #90128.
--json=future-incompat was stabilized in #91535.

@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2022
@apiraino
Copy link
Contributor

apiraino commented Apr 28, 2022

Checking current progress of this. By reading the last comments I think it's waiting for a review from @Mark-Simulacrum ? thanks for an update!

(if I understand, this should unlock #89917)

@ehuss
Copy link
Contributor Author

ehuss commented Apr 28, 2022

Yea, the summary at #93661 (comment) is the latest. Perhaps @joshtriplett or some person on the compiler team would be willing to review?

@apiraino
Copy link
Contributor

apiraino commented Apr 28, 2022

Yea, the summary at #93661 (comment) is the latest. Perhaps @joshtriplett or some person on the compiler team would be willing to review?

let's try :)

r? rust-lang/compiler

@ehuss
Copy link
Contributor Author

ehuss commented Apr 30, 2022

I don't think highfive listens to comment edits, and the first one didn't have the correct team name.

r? rust-lang/compiler

@estebank
Copy link
Contributor

estebank commented May 4, 2022

I'm r=me on the changes, but ccing @rust-lang/compiler for awareness.

@ehuss
Copy link
Contributor Author

ehuss commented May 9, 2022

OK, I'm going to go ahead and approve. I'll follow up with pulling in the RFC when this merges.

@bors r=estebank,Mark-Simulacrum rollup

@bors
Copy link
Collaborator

bors commented May 9, 2022

📌 Commit 800e0e2 has been approved by estebank,Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#93661 (Add missing rustc arg docs)
 - rust-lang#96674 (docs: add link explaining variance to NonNull docs)
 - rust-lang#96812 (Do not lint on explicit outlives requirements from external macros.)
 - rust-lang#96823 (Properly fix rust-lang#96638)
 - rust-lang#96872 (make sure ScalarPair enums have ScalarPair variants; add some layout sanity checks)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd83ae2 into rust-lang:master May 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 10, 2022
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 27, 2023
…rister

Add documentation on v0 symbol mangling.

This adds official documentation for the v0 symbol mangling format, migrating the documentation from [RFC 2603](https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).
The format was originally stabilized as the `-C symbol-mangling-version` option, but the specifics were not stabilized (per rust-lang#90128 (comment)).
Per the discussion at rust-lang#93661 (comment) this adds those specifics as an official description of the format.

cc rust-lang#89917
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2023
…ster

Add documentation on v0 symbol mangling.

This adds official documentation for the v0 symbol mangling format, migrating the documentation from [RFC 2603](https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).
The format was originally stabilized as the `-C symbol-mangling-version` option, but the specifics were not stabilized (per rust-lang#90128 (comment)).
Per the discussion at rust-lang#93661 (comment) this adds those specifics as an official description of the format.

cc rust-lang#89917
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 30, 2023
Add documentation on v0 symbol mangling.

This adds official documentation for the v0 symbol mangling format, migrating the documentation from [RFC 2603](https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).
The format was originally stabilized as the `-C symbol-mangling-version` option, but the specifics were not stabilized (per rust-lang/rust#90128 (comment)).
Per the discussion at rust-lang/rust#93661 (comment) this adds those specifics as an official description of the format.

cc #89917
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
Add documentation on v0 symbol mangling.

This adds official documentation for the v0 symbol mangling format, migrating the documentation from [RFC 2603](https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).
The format was originally stabilized as the `-C symbol-mangling-version` option, but the specifics were not stabilized (per rust-lang/rust#90128 (comment)).
Per the discussion at rust-lang/rust#93661 (comment) this adds those specifics as an official description of the format.

cc #89917
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Add documentation on v0 symbol mangling.

This adds official documentation for the v0 symbol mangling format, migrating the documentation from [RFC 2603](https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html).
The format was originally stabilized as the `-C symbol-mangling-version` option, but the specifics were not stabilized (per rust-lang/rust#90128 (comment)).
Per the discussion at rust-lang/rust#93661 (comment) this adds those specifics as an official description of the format.

cc #89917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants