Document that pre-expansion lint passes are softly deprecated #94397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
changed the title
|
@bors r+ rollup |
|
📌 Commit 2bf56b9 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 26, 2022
…ion, r=cjgillot Document that pre-expansion lint passes are softly deprecated The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it. That's it. Have a great rest of the day 🙃 --- * See [rust#69838](rust-lang#69838) * See [rust-clippy#5518](rust-lang/rust-clippy#5518)
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 27, 2022
…ion, r=cjgillot Document that pre-expansion lint passes are softly deprecated The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it. That's it. Have a great rest of the day 🙃 --- * See [rust#69838](rust-lang#69838) * See [rust-clippy#5518](rust-lang/rust-clippy#5518)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 27, 2022
…ion, r=cjgillot Document that pre-expansion lint passes are softly deprecated The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it. That's it. Have a great rest of the day 🙃 --- * See [rust#69838](rust-lang#69838) * See [rust-clippy#5518](rust-lang/rust-clippy#5518)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 28, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#94396 (1 - Make more use of `let_chains`) - rust-lang#94397 (Document that pre-expansion lint passes are softly deprecated) - rust-lang#94399 (Add test for rust-lang#79465 to prevent regression) - rust-lang#94409 (avoid rebuilding bootstrap when PATH changes) - rust-lang#94415 (Use the first codegen backend in the config.toml as default) - rust-lang#94417 (Fix duplicated impl links) - rust-lang#94420 (3 - Make more use of `let_chains`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-expansion lint pass has been softly deprecated since #69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it.
That's it. Have a great rest of the day 🙃