compiletest: Fix --exact test filtering
#146501
Merged
+54
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
|
rustbot has assigned @Mark-Simulacrum. Use |
Enselic
force-pushed
the
x-test-filter
branch
from
2c8db37 to
733d8a2
Compare
This comment has been minimized.
This comment has been minimized.
This fix only changes the behavior when using `--exact` test filtering,
which was quite broken. Before this fix, the following runs 0 tests:
$ ./x test tests/run-make/crate-loading -- --exact
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 431 filtered out; finished in 24.95µs
With the fix the desired test is run:
$ ./x test tests/run-make/crate-loading -- --exact
running 1 tests
test [run-make] tests/run-make/crate-loading ... ok
Without `--exact` the set of run tests is unchanged. This still runs
"too many" tests
$ ./x test tests/run-make/crate-loading
running 3 tests
test [run-make] tests/run-make/crate-loading-crate-depends-on-itself ... ok
test [run-make] tests/run-make/crate-loading-multiple-candidates ... ok
test [run-make] tests/run-make/crate-loading ... ok
This still runs the one and only right test:
$ ./x test tests/ui/lint/unused/unused-allocation.rs
running 1 tests
test [ui] tests/ui/lint/unused/unused-allocation.rs ... ok
Enselic
force-pushed
the
x-test-filter
branch
from
733d8a2 to
a48c8e3
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 15, 2025
Rollup of 8 pull requests Successful merges: - #143314 (add reference id to test, and fix filename) - #146284 (Remove `div_rem` from `core::num::bignum`) - #146416 (Tidy dependency checks cleanups + QoL) - #146471 (bootstrap: Show target in "No such target exists" message) - #146478 (Improve `core::fmt` coverage) - #146480 (tests: update new test to accept new lifetime format) - #146488 (Improve `core::ptr` coverage) - #146501 (compiletest: Fix `--exact` test filtering) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 15, 2025
Rollup merge of #146501 - Enselic:x-test-filter, r=Mark-Simulacrum compiletest: Fix `--exact` test filtering This fix only changes the behavior when using `--exact` test filtering, which was quite broken. Before this fix, the following runs 0 tests: $ ./x test tests/run-make/crate-loading -- --exact running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 431 filtered out; finished in 24.95µs With the fix the desired test is run: $ ./x test tests/run-make/crate-loading -- --exact running 1 tests test [run-make] tests/run-make/crate-loading ... ok Without `--exact` the set of run tests is unchanged. This still runs "too many" (cc #134341) tests $ ./x test tests/run-make/crate-loading running 3 tests test [run-make] tests/run-make/crate-loading-crate-depends-on-itself ... ok test [run-make] tests/run-make/crate-loading-multiple-candidates ... ok test [run-make] tests/run-make/crate-loading ... ok This still runs the one and only right test $ ./x test tests/ui/lint/unused/unused-allocation.rs running 1 tests test [ui] tests/ui/lint/unused/unused-allocation.rs ... ok ### Notes - I have not verified this on Windows which treats paths differently (but I see no reason why it should not work since my code should be platform agnostic).
|
This seems to have broken test filtering when not using > ./x test tests/ui --keep-stage 1 --test-args tests/ui --force-rerun
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 19788 filtered out; finished in 23.01µs |
|
Thanks for the ping. Looking into it right now. Expecting the fix to be easy. I'll keep you updated. |
|
Seems fixed by #146601. I'll do some more testing while PR CI runs. Edit: That PR seems ok according to my testing. |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 16, 2025
…lacrum compiletest: Make `./x test --test-args ...` work again It accidentally broke with rust-lang#146501. The intention of that PR was to keep existing behavior if `--exact` is not used, but it had a bug. This PR fixes that bug.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 17, 2025
compiletest: Make `./x test --test-args ...` work again It accidentally broke with rust-lang/rust#146501. The intention of that PR was to keep existing behavior if `--exact` is not used, but it had a bug. This PR fixes that bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix only changes the behavior when using
--exacttest filtering, whichwas quite broken. Before this fix, the following runs 0 tests:
With the fix the desired test is run:
Without
--exactthe set of run tests is unchanged. This still runs "too many" (cc #134341) testsThis still runs the one and only right test
Notes