Skip to content

Tidy dependency checks cleanups + QoL #146416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 15, 2025
Merged

Tidy dependency checks cleanups + QoL #146416

merged 5 commits into from
Sep 15, 2025

Conversation

clubby789
Copy link
Contributor

  • Refactors the list of workspaces into a documented struct
  • Provide accurate line info in 'Go to ..... for the list' message
  • Print crate name on dependency issue (i.e. dependency for rustc-main instead of dependency for .

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu

This comment was marked as off-topic.

Sign in to view

@jieyouxu jieyouxu dismissed their stale review September 13, 2025 05:01

Apparently I only looked at commit 1, somehow

jieyouxu
jieyouxu approved these changes Sep 13, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a tiny nit

View changes since this review

src/tools/tidy/src/deps.rs
};
}

const PERMITTED_RUSTC_DEPS_LOCATION: ListLocation = location!(+6);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: wow I didn't realize we even had these location hints... cheeky.

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 13, 2025
@clubby789
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2025
jieyouxu
jieyouxu approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 15, 2025

📌 Commit 37d058f has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 15, 2025
Merged
bors added a commit that referenced this pull request Sep 15, 2025
@bors
Auto merge of #146572 - matthiaskrgr:rollup-gotklb6, r=matthiaskrgr
d1ed52b 
Rollup of 8 pull requests

Successful merges:

 - #143314 (add reference id to test, and fix filename)
 - #146284 (Remove `div_rem` from `core::num::bignum`)
 - #146416 (Tidy dependency checks cleanups + QoL)
 - #146471 (bootstrap: Show target in "No such target exists" message)
 - #146478 (Improve `core::fmt` coverage)
 - #146480 (tests: update new test to accept new lifetime format)
 - #146488 (Improve `core::ptr` coverage)
 - #146501 (compiletest: Fix `--exact` test filtering)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b59f0a2 into rust-lang:master Sep 15, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 15, 2025
rust-timer added a commit that referenced this pull request Sep 15, 2025
@rust-timer
Unrolled build for #146416
b242ea2 
Rollup merge of #146416 - clubby789:tidy-deps-qol, r=jieyouxu

Tidy dependency checks cleanups + QoL

- Refactors the list of workspaces into a documented struct
- Provide accurate line info in 'Go to ..... for the list' message
- Print crate name on dependency issue (i.e. `dependency for rustc-main` instead of `dependency for .`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
4 participants
@clubby789 @rustbot @jieyouxu @bors