interpret: fix overlapping aggregate initialization #146402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
force-pushed
the
aggregate-init
branch
2 times, most recently
from
48c050f to
84d6318
Compare
This comment has been minimized.
This comment has been minimized.
|
sounds incredibly cool, u should assign this to someone other than me because I have no idea what is going on here :3 |
|
r? @saethlin |
RalfJung
force-pushed
the
aggregate-init
branch
from
84d6318 to
a0d817c
Compare
|
This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @vakaras |
RalfJung
force-pushed
the
aggregate-init
branch
from
a3a44eb to
4c33b9c
Compare
|
Some changes occurred in compiler/rustc_codegen_ssa |
RalfJung
force-pushed
the
aggregate-init
branch
from
4c33b9c to
94493d5
Compare
This comment has been minimized.
This comment has been minimized.
and double-check that we match it in codegen
RalfJung
force-pushed
the
aggregate-init
branch
from
94493d5 to
7222506
Compare
|
@bors r+ rollup=iffy (likely suspect if this ends up in a rollup with a perf change) |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 14, 2025
interpret: fix overlapping aggregate initialization This fixes the problem pointed out by `@saethlin` in #146383 (comment). Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 15, 2025
interpret: fix overlapping aggregate initialization This fixes the problem pointed out by `@saethlin` in rust-lang#146383 (comment). Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.
bors
added a commit
that referenced
this pull request
Sep 15, 2025
Rollup of 8 pull requests Successful merges: - #146402 (interpret: fix overlapping aggregate initialization) - #146530 (rustc_codegen_llvm: Adjust RISC-V inline assembly's clobber list) - #146533 (Note some previous attempts to change the Default impl for `[T; 0]`) - #146539 (fix 404 MCP link) - #146546 (Switch `std::vec::PeekMut::pop` from self to this parameter.) - #146549 (On FreeBSD, use readdir instead of readdir_r) - #146559 (Fix typo in error message) - #146563 (bootstrap.py: disable incremental build for bootstrap in CI) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 15, 2025
Rollup of 8 pull requests Successful merges: - #146402 (interpret: fix overlapping aggregate initialization) - #146530 (rustc_codegen_llvm: Adjust RISC-V inline assembly's clobber list) - #146533 (Note some previous attempts to change the Default impl for `[T; 0]`) - #146539 (fix 404 MCP link) - #146546 (Switch `std::vec::PeekMut::pop` from self to this parameter.) - #146549 (On FreeBSD, use readdir instead of readdir_r) - #146559 (Fix typo in error message) - #146563 (bootstrap.py: disable incremental build for bootstrap in CI) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 15, 2025
Rollup of 8 pull requests Successful merges: - #146402 (interpret: fix overlapping aggregate initialization) - #146530 (rustc_codegen_llvm: Adjust RISC-V inline assembly's clobber list) - #146533 (Note some previous attempts to change the Default impl for `[T; 0]`) - #146539 (fix 404 MCP link) - #146546 (Switch `std::vec::PeekMut::pop` from self to this parameter.) - #146549 (On FreeBSD, use readdir instead of readdir_r) - #146559 (Fix typo in error message) - #146563 (bootstrap.py: disable incremental build for bootstrap in CI) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 15, 2025
interpret: fix overlapping aggregate initialization This fixes the problem pointed out by ``@saethlin`` in rust-lang#146383 (comment). Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 15, 2025
interpret: fix overlapping aggregate initialization This fixes the problem pointed out by ```@saethlin``` in rust-lang#146383 (comment). Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.
bors
added a commit
that referenced
this pull request
Sep 15, 2025
Rollup of 12 pull requests Successful merges: - #146338 (Extends AArch64 branch protection support to include GCS) - #146344 (tests/codegen-llvm: Make rust-abi-arch-specific-adjustment portable) - #146402 (interpret: fix overlapping aggregate initialization) - #146405 (Add relnotes for 1.90.0) - #146530 (rustc_codegen_llvm: Adjust RISC-V inline assembly's clobber list) - #146533 (Note some previous attempts to change the Default impl for `[T; 0]`) - #146539 (fix 404 MCP link) - #146546 (Switch `std::vec::PeekMut::pop` from self to this parameter.) - #146549 (On FreeBSD, use readdir instead of readdir_r) - #146559 (Fix typo in error message) - #146563 (bootstrap.py: disable incremental build for bootstrap in CI) - #146576 (opt-dist: don't set `RUST_LOG=collector=debug`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup of 9 pull requests Successful merges: - #145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - #145960 (Split `FnCtxt::report_args_error` into subfunctions) - #146402 (interpret: fix overlapping aggregate initialization) - #146466 (llvm-wrapper: other cleanup) - #146574 (compiletest: Enable new-output-capture by default) - #146599 (replace some `#[const_trait]` with `const trait`) - #146601 (compiletest: Make `./x test --test-args ...` work again) - #146608 (improve internal bootstrap docs) - #146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 16, 2025
interpret: fix overlapping aggregate initialization This fixes the problem pointed out by `@saethlin` in #146383 (comment). Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.
|
Yield to enclosing rollup, which failed due to a GitHub runner flaking out. @bors retry |
bors
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup of 9 pull requests Successful merges: - #145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - #145960 (Split `FnCtxt::report_args_error` into subfunctions) - #146402 (interpret: fix overlapping aggregate initialization) - #146466 (llvm-wrapper: other cleanup) - #146574 (compiletest: Enable new-output-capture by default) - #146599 (replace some `#[const_trait]` with `const trait`) - #146601 (compiletest: Make `./x test --test-args ...` work again) - #146608 (improve internal bootstrap docs) - #146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup merge of #146402 - RalfJung:aggregate-init, r=saethlin interpret: fix overlapping aggregate initialization This fixes the problem pointed out by ````@saethlin```` in #146383 (comment). Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 17, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - rust-lang/rust#145960 (Split `FnCtxt::report_args_error` into subfunctions) - rust-lang/rust#146402 (interpret: fix overlapping aggregate initialization) - rust-lang/rust#146466 (llvm-wrapper: other cleanup) - rust-lang/rust#146574 (compiletest: Enable new-output-capture by default) - rust-lang/rust#146599 (replace some `#[const_trait]` with `const trait`) - rust-lang/rust#146601 (compiletest: Make `./x test --test-args ...` work again) - rust-lang/rust#146608 (improve internal bootstrap docs) - rust-lang/rust#146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem pointed out by @saethlin in #146383 (comment).
Also clarify when exactly current de-facto MIR semantics allow overlap of the LHS and RHS in an assignment.