Skip to content

Update getopts to remove unicode-width dependency #146001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Update getopts to remove unicode-width dependency #146001

merged 1 commit into from
Sep 9, 2025
+6 −18

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 29, 2025

Pulls in rust-lang/getopts#133. This saves 1.5MB on the vendored size of the standard library.

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@bjorn3
Copy link
Member Author

bjorn3 commented Sep 5, 2025

You mean I can do bors r=davidtwco?

@davidtwco
Copy link
Member

Sorry, yes

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 9, 2025

📌 Commit b0897f3 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 9, 2025
Merged
bors added a commit that referenced this pull request Sep 9, 2025
@bors
Auto merge of #146375 - matthiaskrgr:rollup-utik9zj, r=matthiaskrgr
7ad23f4 
Rollup of 6 pull requests

Successful merges:

 - #145463 (Reject invalid literal suffixes in tuple indexing, tuple struct indexing, and struct field name position)
 - #145929 (fix APITIT being treated as a normal generic parameter in suggestions)
 - #146001 (Update getopts to remove unicode-width dependency)
 - #146365 (triagebot: warn about #[rustc_intrinsic_const_stable_indirect])
 - #146366 (add approx_delta to all gamma tests)
 - #146373 (fix comments about trait solver cycle heads)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f46ddba into rust-lang:master Sep 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 9, 2025
rust-timer added a commit that referenced this pull request Sep 9, 2025
@rust-timer
Unrolled build for #146001
dfff02d 
Rollup merge of #146001 - bjorn3:update_getopts, r=davidtwco

Update getopts to remove unicode-width dependency

Pulls in rust-lang/getopts#133. This saves 1.5MB on the vendored size of the standard library.
@bjorn3 bjorn3 deleted the update_getopts branch September 10, 2025 08:52
@github-actions github-actions bot mentioned this pull request Sep 10, 2025
Draft
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Sep 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#146001 - bjorn3:update_getopts, r=davidtwco
2632cda 
Update getopts to remove unicode-width dependency

Pulls in rust-lang/getopts#133. This saves 1.5MB on the vendored size of the standard library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@ibraheemdev ibraheemdev

Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rustbot @davidtwco @bors @ibraheemdev