Skip to content

Make unicode-width an optional default dependency #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 29, 2025
Merged

Make unicode-width an optional default dependency #133

merged 4 commits into from
Aug 29, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 22, 2025

Closes #132

@bjorn3 bjorn3 mentioned this pull request Aug 22, 2025
Closed
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 22, 2025

Can we bump the MSRV to 1.68? That is the first version stabilizing the sparse registry. Due to the lack of sparse registry support the MSRV job currently takes several minutes while all other jobs finish in half a minute.

@the8472
Copy link
Member

the8472 commented Aug 22, 2025

I haven't found anything explicitly saying what semver policy around default features is, but this could be a breaking change for default-features=false dependents... but currently there only is rustc-dep-of-std which hopefully nobody but std is using, so it's probably fine.

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 22, 2025

The worst thing that can happen when disabling this feature unintentionally is that the help text is twice as wide as it should be causing wrapping inside a terminal.

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 29, 2025

Is there anything that needs to be done for this to be merged?

@the8472
Copy link
Member

the8472 commented Aug 29, 2025

Ah sorry, I assumed you had permission.

@the8472 the8472 merged commit 03ce599 into rust-lang:master Aug 29, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2025
Merged
@bjorn3 bjorn3 deleted the optional_unicode_width branch August 29, 2025 11:20
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 29, 2025

I technically do have write permission, but I figured I shouldn't use it given that I never touched this crate before.

@bjorn3 bjorn3 mentioned this pull request Aug 29, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#146001 - bjorn3:update_getopts, r=davidtwco
f46ddba 
Update getopts to remove unicode-width dependency

Pulls in rust-lang/getopts#133. This saves 1.5MB on the vendored size of the standard library.
rust-timer added a commit to rust-lang/rust that referenced this pull request Sep 9, 2025
@rust-timer
Unrolled build for #146001
dfff02d 
Rollup merge of #146001 - bjorn3:update_getopts, r=davidtwco

Update getopts to remove unicode-width dependency

Pulls in rust-lang/getopts#133. This saves 1.5MB on the vendored size of the standard library.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Sep 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#146001 - bjorn3:update_getopts, r=davidtwco
2632cda 
Update getopts to remove unicode-width dependency

Pulls in rust-lang/getopts#133. This saves 1.5MB on the vendored size of the standard library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does getopts actually need to depend on unicode-width?
2 participants
@bjorn3 @the8472