Gate static closures behind a parser feature #145604
Conversation
|
@bors2 try |
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
|
Gate static closures behind a parser feature
This comment has been minimized.
This comment has been minimized.
|
r=me if crater results look good (they should); no T-lang input necessary imho |
fmease
added
S-waiting-on-author
|
@craterbot check |
1 similar comment
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
(I get 504 Gateway Time-out from crater.rust-lang.org) @craterbot ping |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
All regressions are spurious. |
|
@bors r+ rollup (no T-lang input necessary) |
bors
added
S-waiting-on-bors
fmease
added
the
relnotes
Surely this change is fine, but crater is still partially broken: 178K crates were not tested in this run :/ |
Rollup of 16 pull requests Successful merges: - #137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again) - #144541 (c-variadic: multiple ABIs in the same program for arm) - #144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).) - #144780 (Add a method to dump MIR in the middle of MIR building) - #145137 (Consolidate panicking functions in `slice/index.rs`) - #145507 (Refactor attribute parsing to improve ergonomics and some diagnostics) - #145604 (Gate static closures behind a parser feature) - #145648 (Add two tidy dependency checks) - #145661 (update some s390x codegen tests) - #145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability) - #145689 (Migrate `panic_unwind` to use `cfg_select!`) - #145700 (Handle `ReEarlyParam` in `type_name`.) - #145703 (Remove MIPS targets from CI LLVM platforms) - #145704 (ci: don't cleanup windows disk) - #145705 (remove an `as` cast in prefetch codegen) - #145712 (Update outdated link in bound region comments) r? `@ghost` `@rustbot` modify labels: rollup
It's quite unfortunate but not specific to this PR / crater run. That's been the case for the last 6+ (12+ ?) months IINM. E.g., https://crater-reports.s3.amazonaws.com/pr-145605/index.html, https://crater-reports.s3.amazonaws.com/pr-145463/index.html, https://crater-reports.s3.amazonaws.com/pr-144386/index.html, https://crater-reports.s3.amazonaws.com/pr-142134-abi-ast-error/index.html. Prior to some crater patch from maybe 6 months ago that introduced prepare-fail, such failures were simply grouped under error, see e.g. https://crater-reports.s3.amazonaws.com/pr-138952/index.html. |
Rollup merge of #145604 - compiler-errors:static-closure, r=fmease Gate static closures behind a parser feature I'd like to gate `static ||` closures behind a feature gate, since we shouldn't allow people to take advantage of this syntax if it's currently unstable. Right now, since it's only rejected after ast lowering, it's accessible to macros. Let's crater this to see if we can claw it back without breaking anyone's code.
Rollup of 16 pull requests Successful merges: - rust-lang/rust#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again) - rust-lang/rust#144541 (c-variadic: multiple ABIs in the same program for arm) - rust-lang/rust#144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).) - rust-lang/rust#144780 (Add a method to dump MIR in the middle of MIR building) - rust-lang/rust#145137 (Consolidate panicking functions in `slice/index.rs`) - rust-lang/rust#145507 (Refactor attribute parsing to improve ergonomics and some diagnostics) - rust-lang/rust#145604 (Gate static closures behind a parser feature) - rust-lang/rust#145648 (Add two tidy dependency checks) - rust-lang/rust#145661 (update some s390x codegen tests) - rust-lang/rust#145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability) - rust-lang/rust#145689 (Migrate `panic_unwind` to use `cfg_select!`) - rust-lang/rust#145700 (Handle `ReEarlyParam` in `type_name`.) - rust-lang/rust#145703 (Remove MIPS targets from CI LLVM platforms) - rust-lang/rust#145704 (ci: don't cleanup windows disk) - rust-lang/rust#145705 (remove an `as` cast in prefetch codegen) - rust-lang/rust#145712 (Update outdated link in bound region comments) r? `@ghost` `@rustbot` modify labels: rollup
I'd like to gate
static ||closures behind a feature gate, since we shouldn't allow people to take advantage of this syntax if it's currently unstable. Right now, since it's only rejected after ast lowering, it's accessible to macros.Let's crater this to see if we can claw it back without breaking anyone's code.