Implement feature int_lowest_highest_one for integer and NonZero types
#145381
+333
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Gnurou
force-pushed
the
int_lowest_highest_one
branch
from
ed51b06 to
520868b
Compare
This comment has been minimized.
This comment has been minimized.
|
Urk, I overlook something with the |
|
You can use |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Implement the accepted ACP for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types. Also add unit tests for all these types.
Gnurou
force-pushed
the
int_lowest_highest_one
branch
from
520868b to
c140bc1
Compare
jhpratt
reviewed
Aug 14, 2025
Comment on lines
+684
to
+685
| /// Returns the index of the highest bit set to one in `self`, or `None` | ||
| /// if `self` is `0`. |
There was a problem hiding this comment.
Suggested change
| /// Returns the index of the highest bit set to one in `self`, or `None` | |
| /// if `self` is `0`. | |
| /// Returns the index of the highest bit set to one in `self`. |
not needed for NonZero
Comment on lines
+472
to
+473
| const ONE: $T = 1; | ||
| const MINUS_ONE: $T = -1; |
There was a problem hiding this comment.
Why are these constants necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #145203
Implement the accepted ACP #145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.
Also add unit tests for all these types.