Skip to content

Demote x86_64-apple-darwin to Tier 2 with host tools #145252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shepmaster
Copy link
Member

@shepmaster shepmaster commented Aug 11, 2025

Switch to only using aarch64 runners (implying we are now cross-compiling) and stop running tests. In the future, we could enable (some?) tests via Rosetta 2.

This implements the decision from rust-lang/rfcs#3841.

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 11, 2025
@jieyouxu jieyouxu added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 11, 2025
@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-x86_64-apple

@rust-bors
Copy link

rust-bors bot commented Aug 11, 2025

⌛ Trying commit c82a9f2 with merge b05ee4d

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Aug 11, 2025
…-2, r=<try>

Demote x86_64-apple-darwin to Tier 2 with host tools

try-job: dist-x86_64-apple
@jieyouxu
Copy link
Member

Discussed beta backport during infra meeting: #t-infra > meeting 2025-08-11 @ 💬

@rustbot label: +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 11, 2025
@ehuss ehuss added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 11, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 11, 2025

💔 Test for b05ee4d failed: CI. Failed jobs:

@shepmaster shepmaster force-pushed the demote-x86_64-apple-darwin-to-tier-2 branch from c82a9f2 to 5d3595e Compare August 11, 2025 17:37
@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-x86_64-apple

rust-bors bot added a commit that referenced this pull request Aug 11, 2025
…-2, r=<try>

Demote x86_64-apple-darwin to Tier 2 with host tools

try-job: dist-x86_64-apple
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 11, 2025

💔 Test for c20c6a6 failed: CI. Failed jobs:

@shepmaster shepmaster force-pushed the demote-x86_64-apple-darwin-to-tier-2 branch from 5d3595e to 77e8080 Compare August 12, 2025 15:25
@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

These commits modify compiler targets.
(See the Target Tier Policy.)

@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-x86_64-apple

rust-bors bot added a commit that referenced this pull request Aug 12, 2025
…-2, r=<try>

Demote x86_64-apple-darwin to Tier 2 with host tools

try-job: dist-x86_64-apple
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 12, 2025

💔 Test for 3af1931 failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 15, 2025

💔 Test for 63227c3 failed: CI. Failed jobs:

Switch to only using aarch64 runners (implying we are now
cross-compiling) and stop running tests. In the future, we could
enable (some?) tests via Rosetta 2.
@shepmaster shepmaster force-pushed the demote-x86_64-apple-darwin-to-tier-2 branch from c55b13e to c574c91 Compare August 15, 2025 16:00
@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-x86_64-apple

rust-bors bot added a commit that referenced this pull request Aug 15, 2025
…-2, r=<try>

Demote x86_64-apple-darwin to Tier 2 with host tools

try-job: dist-x86_64-apple
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 15, 2025

☀️ Try build successful (CI)
Build commit: afe02ce (afe02ce9b89b748eaf891b1b747e8066c17025dc, parent: c018ae5389c49cc4bcb8343d80dd8e7323325410)

@shepmaster
Copy link
Member Author

@bors r=Kobzol,madsmtm rollup

@bors
Copy link
Collaborator

bors commented Aug 19, 2025

📌 Commit c574c91 has been approved by Kobzol,madsmtm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2025
@shepmaster
Copy link
Member Author

For record keeping, @Kobzol approved on Zulip

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 19, 2025
…win-to-tier-2, r=Kobzol,madsmtm

Demote x86_64-apple-darwin to Tier 2 with host tools

Switch to only using aarch64 runners (implying we are now cross-compiling) and stop running tests. In the future, we could enable (some?) tests via Rosetta 2.

This implements the decision from rust-lang/rfcs#3841.
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 19, 2025
…win-to-tier-2, r=Kobzol,madsmtm

Demote x86_64-apple-darwin to Tier 2 with host tools

Switch to only using aarch64 runners (implying we are now cross-compiling) and stop running tests. In the future, we could enable (some?) tests via Rosetta 2.

This implements the decision from rust-lang/rfcs#3841.
bors added a commit that referenced this pull request Aug 20, 2025
Rollup of 13 pull requests

Successful merges:

 - #139357 (Fix parameter order for `_by()` variants of `min` / `max`/ `minmax` in `std::cmp`)
 - #140314 (Rustdoc: typecheck scrape-examples.js)
 - #140794 (mention lint group in default level lint note)
 - #145006 (Clarify EOF handling for `BufRead::skip_until`)
 - #145252 (Demote x86_64-apple-darwin to Tier 2 with host tools)
 - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
 - #145381 (Implement feature `int_lowest_highest_one` for integer and NonZero types)
 - #145417 (std_detect: RISC-V platform guide documentation)
 - #145531 (Add runtime detection for APX-F and AVX10)
 - #145619 (`std_detect`: Use `rustc-std-workspace-*` to pull in `compiler-builtins`)
 - #145622 (Remove the std workspace patch for `compiler-builtins`)
 - #145623 (Pretty print the name of an future from calling async closure)
 - #145626 (add a fallback implementation for the `prefetch_*` intrinsics )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7b7ad4d into rust-lang:master Aug 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 20, 2025
rust-timer added a commit that referenced this pull request Aug 20, 2025
Rollup merge of #145252 - shepmaster:demote-x86_64-apple-darwin-to-tier-2, r=Kobzol,madsmtm

Demote x86_64-apple-darwin to Tier 2 with host tools

Switch to only using aarch64 runners (implying we are now cross-compiling) and stop running tests. In the future, we could enable (some?) tests via Rosetta 2.

This implements the decision from rust-lang/rfcs#3841.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 21, 2025
Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#139357 (Fix parameter order for `_by()` variants of `min` / `max`/ `minmax` in `std::cmp`)
 - rust-lang/rust#140314 (Rustdoc: typecheck scrape-examples.js)
 - rust-lang/rust#140794 (mention lint group in default level lint note)
 - rust-lang/rust#145006 (Clarify EOF handling for `BufRead::skip_until`)
 - rust-lang/rust#145252 (Demote x86_64-apple-darwin to Tier 2 with host tools)
 - rust-lang/rust#145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
 - rust-lang/rust#145381 (Implement feature `int_lowest_highest_one` for integer and NonZero types)
 - rust-lang/rust#145417 (std_detect: RISC-V platform guide documentation)
 - rust-lang/rust#145531 (Add runtime detection for APX-F and AVX10)
 - rust-lang/rust#145619 (`std_detect`: Use `rustc-std-workspace-*` to pull in `compiler-builtins`)
 - rust-lang/rust#145622 (Remove the std workspace patch for `compiler-builtins`)
 - rust-lang/rust#145623 (Pretty print the name of an future from calling async closure)
 - rust-lang/rust#145626 (add a fallback implementation for the `prefetch_*` intrinsics )

r? `@ghost`
`@rustbot` modify labels: rollup
@cuviper cuviper mentioned this pull request Aug 21, 2025
@cuviper cuviper modified the milestones: 1.91.0, 1.90.0 Aug 21, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 21, 2025
bors added a commit that referenced this pull request Aug 21, 2025
[beta] backports

- Gate const trait syntax #144956
- Demote x86_64-apple-darwin to Tier 2 with host tools #145252
- Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause #145642

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants