suggest using `pub(crate)` for E0364 #145166

makai410 · 2025-08-09T15:09:58Z

This introduces vis_span into ImportData for diagnostic purposes.
Closes: Teach pub(crate) use for E0364 on macro_rules! #145140

rustbot · 2025-08-09T15:10:03Z

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kivooeo · 2025-08-09T15:30:28Z

compiler/rustc_resolve/messages.ftl

+resolve_consider_marking_as_pub_crate =
+    or if you want to use the macro within this crate only, reduce the visibility to `pub(crate)`
+


Looking at all other resolve_consider_* error messages I found this addition pretty inconsistent with others, all of them starts with "consider" except this one, is there is no particalr reason for it, could you please rewrite it

I just make it align with resolve_consider_marking_as_pub, and "resolve" probably is taken from "rustc_resolve"

Hm, I see, sounds reasonable but I wonder if something like that could probably work here?

resolve_consider_adding_macro_export = consider adding a `#[macro_export]` to the macro in the imported module .help = or if you want to use the macro within this crate only, reduce the visibility to `pub(crate)`

it's not modular enough then IMO

Kivooeo · 2025-08-09T15:37:43Z

tests/ui/macros/teach-pub-crate-on-macro-rules.rs

If this is a regression test, a nice-to-have addition would be a link to the original issue

lcnr · 2025-08-13T08:46:16Z

tests/ui/privacy/macro-private-reexport.stderr

@@ -11,6 +11,10 @@ LL | /     macro_rules! bar {
 LL | |         () => {};
 LL | |     }
   | |_____^
+help: or if you want to use the macro within this crate only, reduce the visibility to `pub(crate)`


Suggested change

help: or if you want to use the macro within this crate only, reduce the visibility to `pub(crate)`

help: in case you want to use the macro within this crate only, reduce the visibility to `pub(crate)`

I feel like the "or" doesn't provide much value here and is not something we do in many other error messages (if at all)

lcnr · 2025-08-13T08:46:32Z

@bors2 try @rust-timer queue

suggest using `pub(crate)` for E0364

rust-bors · 2025-08-13T11:02:06Z

☀️ Try build successful (CI)
Build commit: d9d91c9 (d9d91c9b200cb9e062f3e84ce3e278807e759357, parent: b1b26b834d85e84b46aa8f8f3ce210a1627aa85f)

rust-timer · 2025-08-13T12:59:11Z

Finished benchmarking commit (d9d91c9): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.3%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	2.5%	[2.2%, 2.8%]	2
Improvements ✅ (primary)	-1.1%	[-1.3%, -0.8%]	2
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	-0.3%	[-1.3%, 1.3%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.328s -> 463.676s (-0.14%)
Artifact size: 377.44 MiB -> 377.33 MiB (-0.03%)

lcnr · 2025-08-18T09:04:47Z

@bors r+

bors · 2025-08-18T09:04:49Z

📌 Commit 0c8485f has been approved by lcnr

It is now in the queue for this repository.

lcnr · 2025-08-18T13:41:14Z

The bors queue is very long and I am going to treat the perf impact as small enough rn/nearly meaningless

@bors rollup=always

suggest using `pub(crate)` for E0364 - This introduces `vis_span` into `ImportData` for diagnostic purposes. Closes: rust-lang#145140

Rollup of 33 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes) - #145542 (triagebot: Don't warn no-mentions on subtree updates) - #145549 (Update rust maintainers in openharmony.md) - #145550 (Avoid using `()` in `derive(From)` output.) - #145556 (Allow stability attributes on extern crates) - #145560 (Remove unused `PartialOrd`/`Ord` from bootstrap) - #145568 (ignore frontmatters in `TokenStream::new`) - #145571 (remove myself from some adhoc-groups and pings) - #145576 (Add change tracker entry for `--timings`) r? `@ghost` `@rustbot` modify labels: rollup

suggest using `pub(crate)` for E0364 - This introduces `vis_span` into `ImportData` for diagnostic purposes. Closes: rust-lang#145140

Rollup of 15 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #143730 (fmt of non-decimal radix untangled) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145099 (rustc_target: Add the `32s` target feature for LoongArch) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145166 - makai410:teach-pub-crate, r=lcnr suggest using `pub(crate)` for E0364 - This introduces `vis_span` into `ImportData` for diagnostic purposes. Closes: #145140

Rollup of 15 pull requests Successful merges: - rust-lang#139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - rust-lang#140740 (Add `-Zindirect-branch-cs-prefix`) - rust-lang#142079 (nll-relate: improve hr opaque types support) - rust-lang#142938 (implement std::fs::set_permissions_nofollow on unix) - rust-lang#143730 (fmt of non-decimal radix untangled) - rust-lang#144767 (Correct some grammar in integer documentation) - rust-lang#144906 (Require approval from t-infra instead of t-release on tier bumps) - rust-lang#144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang#145025 (run spellcheck as a tidy extra check in ci) - rust-lang#145099 (rustc_target: Add the `32s` target feature for LoongArch) - rust-lang#145166 (suggest using `pub(crate)` for E0364) - rust-lang#145255 (dec2flt: Provide more valid inputs examples) - rust-lang#145306 (Add tracing to various miscellaneous functions) - rust-lang#145336 (Hide docs for `core::unicode`) - rust-lang#145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - rust-lang/rust#140740 (Add `-Zindirect-branch-cs-prefix`) - rust-lang/rust#142079 (nll-relate: improve hr opaque types support) - rust-lang/rust#142938 (implement std::fs::set_permissions_nofollow on unix) - rust-lang/rust#143730 (fmt of non-decimal radix untangled) - rust-lang/rust#144767 (Correct some grammar in integer documentation) - rust-lang/rust#144906 (Require approval from t-infra instead of t-release on tier bumps) - rust-lang/rust#144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang/rust#145025 (run spellcheck as a tidy extra check in ci) - rust-lang/rust#145099 (rustc_target: Add the `32s` target feature for LoongArch) - rust-lang/rust#145166 (suggest using `pub(crate)` for E0364) - rust-lang/rust#145255 (dec2flt: Provide more valid inputs examples) - rust-lang/rust#145306 (Add tracing to various miscellaneous functions) - rust-lang/rust#145336 (Hide docs for `core::unicode`) - rust-lang/rust#145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Aug 9, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 9, 2025

This comment has been minimized.

Sign in to view

makai410 force-pushed the teach-pub-crate branch from 9c83c95 to f0b2b1a Compare August 9, 2025 15:17

Kivooeo reviewed Aug 9, 2025

View reviewed changes

makai410 force-pushed the teach-pub-crate branch from f0b2b1a to f3d1425 Compare August 11, 2025 15:53

lcnr reviewed Aug 13, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 13, 2025

Auto merge of #145166 - makai410:teach-pub-crate, r=<try>

d9d91c9

suggest using `pub(crate)` for E0364

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2025

This comment has been minimized.

Sign in to view

makai410 force-pushed the teach-pub-crate branch from f3d1425 to 2d24349 Compare August 13, 2025 12:20

suggest using pub(crate) for E0364

0c8485f

makai410 force-pushed the teach-pub-crate branch from 2d24349 to 0c8485f Compare August 13, 2025 12:22

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025

jhpratt mentioned this pull request Aug 18, 2025

Rollup of 33 pull requests #145588

Closed

This was referenced Aug 19, 2025

Rollup of 17 pull requests #145598

Closed

Rollup of 15 pull requests #145599

Merged

bors merged commit 8568070 into rust-lang:master Aug 19, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 19, 2025

rust-timer added a commit that referenced this pull request Aug 19, 2025

Unrolled build for #145166

d150811

Rollup merge of #145166 - makai410:teach-pub-crate, r=lcnr suggest using `pub(crate)` for E0364 - This introduces `vis_span` into `ImportData` for diagnostic purposes. Closes: #145140

		resolve_consider_marking_as_pub_crate =
		or if you want to use the macro within this crate only, reduce the visibility to `pub(crate)`

	help: or if you want to use the macro within this crate only, reduce the visibility to `pub(crate)`
	help: in case you want to use the macro within this crate only, reduce the visibility to `pub(crate)`

suggest using pub(crate) for E0364 #145166

suggest using pub(crate) for E0364 #145166

Conversation

makai410 commented Aug 9, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

This comment has been minimized.

Kivooeo Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr commented Aug 13, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Aug 13, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Aug 13, 2025

Overall result: ❌ regressions - no action needed

Uh oh!

lcnr commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

lcnr commented Aug 18, 2025

Uh oh!

Uh oh!

Uh oh!

suggest using `pub(crate)` for E0364 #145166

suggest using `pub(crate)` for E0364 #145166

makai410 commented Aug 9, 2025 •

edited by rustbot

Loading

Kivooeo Aug 9, 2025 •

edited

Loading

Kivooeo Aug 9, 2025 •

edited

Loading