run spellcheck as a tidy extra check in ci #145025

lolbinarycat · 2025-08-06T22:22:49Z

This is probably how it should've been done from the start.

rustbot · 2025-08-06T22:22:57Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

Kobzol · 2025-08-07T12:58:27Z

I would suggest preinstalling the typos binary in the tidy Dockerfile (by downloading a pinned version from GH releases), and then also adding some download functionality from GitHub releases for local execution (or just use cargo install probably easier), same as how tidy installs Python/JS deps for the user.

klensy · 2025-08-08T18:30:37Z

Can you keep previous logic: check version first and only if not found/wrong build it? I have typos in PATH downloaded from github and not build via cargo, so current logic will build second one for me.

P.S. in case of building typos, it will be nice to drop note in log like building typos or smth.

okaneco · 2025-08-09T00:23:48Z

src/build_helper/src/util.rs

@@ -66,3 +67,65 @@ pub fn parse_gitmodules(target_dir: &Path) -> Vec<String> {

    submodules_paths
 }
+
+/// If the given executible is installed with the given version, use that,


Suggested change

/// If the given executible is installed with the given version, use that,

/// If the given executable is installed with the given version, use that,

you would really think that enabling typo checking would catch that ^^;

Kobzol

The comment on top of SPELLCHECK_DIRS is outdated, could you remove it please?

The build of typos seems to take ~1 minute on CI. We could try to build it with --debug, or preinstall it in the Dockerfile, but in any case 1 minute isn't so terrible.

Kobzol · 2025-08-09T08:26:09Z

src/build_helper/src/util.rs

+
+/// If the given executible is installed with the given version, use that,
+/// otherwise install via cargo.
+pub fn ensure_version_or_cargo_install(


Let's move this to tidy. It's only used in one place now, no need to increase bootstrap's (and other tools') build time by putting it into build_helper.

lolbinarycat · 2025-08-09T16:34:09Z

The build of typos seems to take ~1 minute on CI. We could try to build it with --debug, or preinstall it in the Dockerfile, but in any case 1 minute isn't so terrible.

this seems like the exact usecase for opt-level 1 or 2, where you care about minimizing run + build time. i'll do local testing to see what works best.

UPDATE: local testing seems very noisy, opt level 0 was fastest, but then weirdly 3 was next fastest, with 1 and 2 being almost twice as slow as the others. this seems strange, as the non-rebuild runtime of tidy seemed about the same no matter the opt level. I guess we can just stick -Copt-level=0 in RUSTFLAGS, since it doesn't seem like typos relies much on optimizations being enabled. preinstalling in the Dockerfile also seems like a good idea, but I don't know enough about docker or github releases to do that properly (we do need to make sure the versions stay in sync, tho, probably with a .version file)

Kobzol · 2025-08-11T18:03:47Z

Looks like it takes ~1.5 minutes now. Could you please add some log like "starting/ending spellcheck" that could be used to figure out how much time is spent on installing/building typos and how much time is actually spent on running it?

lolbinarycat · 2025-08-11T18:08:11Z

@Kobzol does this look good? I could also disable the --quiet flag when building in CI.

Kobzol · 2025-08-13T05:01:08Z

Ah, I know. You just reran the CI workflow, but that uses the old merge/master commit that it had previously. That's why it's needed to force push :)

bors · 2025-08-15T13:44:50Z

☔ The latest upstream changes (presumably #145423) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-08-16T14:53:29Z

This PR was rebased onto a different master commit! Check out the changes with our range-diff.

fmease · 2025-08-17T02:40:14Z

@bors r=Kobzol

bors · 2025-08-17T02:40:17Z

📌 Commit 2050a3b has been approved by Kobzol

It is now in the queue for this repository.

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? `@Kobzol`

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? ``@Kobzol``

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? ````@Kobzol````

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? `````@Kobzol`````

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145486 (Fix `unicode_data.rs` mention message) - #145489 (library: Migrate from `cfg_if` to `cfg_select`) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145516 (Weekly `cargo update`) - #145533 (Reorder `lto` options from most to least optimizing) - #145550 (Avoid using `()` in `derive(From)` output.) r? `@ghost` `@rustbot` modify labels: rollup

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? ``````@Kobzol``````

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? `@Kobzol`

…=Kobzol run spellcheck as a tidy extra check in ci This is probably how it should've been done from the start. r? ``@Kobzol``

rustbot assigned Kobzol Aug 6, 2025