Port `#[link]` to the new attribute parsing infrastructure #143193

JonathanBrouwer · 2025-06-29T13:34:29Z

Ports link to the new attribute parsing infrastructure for #131229 (comment)

bors · 2025-06-30T18:52:15Z

☔ The latest upstream changes (presumably #143233) made this pull request unmergeable. Please resolve the merge conflicts.

JonathanBrouwer · 2025-07-16T11:47:50Z

compiler/rustc_attr_data_structures/src/attributes.rs

+    PrintAttribute
+)]
+#[derive(HashStable_Generic)]
+pub enum NativeLibKind {


This type was moved here because it is needed for the link attribute and the original location caused a dependency cycle

JonathanBrouwer · 2025-07-16T11:50:16Z

tests/crashes/120175.rs


-#[link(name = "bar", import_name_type = "decorated", kind = "raw-dylib")]
+#[link(name = "bar", kind = "raw-dylib")]


This test is not testing for the invalid attribute, but instead for the link attribute on an extern type. Because attributes are parsed earlier and this attribute was invalid the error blocked the crash from happening. This is true for quite a few other of the test changes as well

JonathanBrouwer · 2025-07-16T11:51:39Z

tests/ui/attributes/malformed-attrs.rs

@@ -81,8 +81,7 @@
 #[export_stable = 1]
 //~^ ERROR malformed
 #[link]
-//~^ ERROR attribute must be of the form
-//~| WARN this was previously accepted by the compiler
+//~^ ERROR malformed


BREAKING CHANGE 1: A #[link] attribute which is not a list #[link(...)] used to be a warning future error, is now an error. This needs a crater run.

JonathanBrouwer · 2025-07-16T11:52:14Z

tests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs

@@ -61,7 +61,7 @@
 #![doc = "2400"]
 #![cold] //~ WARN attribute should be applied to a function
 //~^ WARN this was previously accepted
-#![link()] //~ WARN attribute should be applied to an `extern` block
+#![link(name = "x")] //~ WARN attribute should be applied to an `extern` block


BREAKING CHANGE 2: A link attribute applied to an invalid target was not checked for syntactic correctness, it now is. The invalid target remains a warning, but the syntactic corectness is now checked

JonathanBrouwer · 2025-07-16T12:25:15Z

@rustbot ready
r? @jdonszelmann

Needs a crater run

rustbot · 2025-07-16T12:25:21Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-07-16T12:25:25Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

jdonszelmann · 2025-07-16T12:42:04Z

@bors try @craterbot queue

Port `#[link]` to the new attribute parsing infrastructure Ports `link` to the new attribute parsing infrastructure for #131229 (comment) This rework is not yet finished, it is blocked on the `cfg` attribute being finished, since `link` takes a `cfg` attribute as argument `@rustbot` blocked

bors · 2025-07-16T12:43:15Z

⌛ Trying commit 6b10a20 with merge 4797991...

bors · 2025-07-16T15:00:28Z

☀️ Try build successful - checks-actions
Build commit: 4797991 (4797991aa2efb6d658150f10425b3f3b5d10eceb)

jdonszelmann · 2025-07-16T16:59:30Z

@craterbot queue

craterbot · 2025-07-16T16:59:32Z

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

jdonszelmann · 2025-08-25T16:16:43Z

yea alright, that looks better. @bors r+ rollup

bors · 2025-08-25T16:16:47Z

📌 Commit ff053ba has been approved by jdonszelmann

It is now in the queue for this repository.

…nszelmann Port `#[link]` to the new attribute parsing infrastructure Ports `link` to the new attribute parsing infrastructure for rust-lang#131229 (comment)

Rollup of 12 pull requests Successful merges: - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #144373 (remove deprecated Error::description in impls) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

…nszelmann Port `#[link]` to the new attribute parsing infrastructure Ports `link` to the new attribute parsing infrastructure for rust-lang#131229 (comment)

Rollup of 13 pull requests Successful merges: - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) - #145858 (Update wasm-component-ld dependency) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-08-26T04:18:08Z

Failed in rollup, in a Windows-specific test: #145865 (comment)

@bors r-

jdonszelmann · 2025-08-26T07:02:15Z

:/

ChrisDenton · 2025-08-26T08:16:11Z

Would it be possible to change the test to a check-pass and set the target instead of only running on x86 windows host?

JonathanBrouwer · 2025-08-26T08:27:32Z

Hmmm that seems reasonable for at least this specific test. There's actually a bunch of windows only tests for link, I'll see how many I can convert

ChrisDenton · 2025-08-26T08:34:35Z

I quickly tried this. Here's what I came up with:

//@ add-core-stubs
//@ check-pass
//@ compile-flags: --target i686-pc-windows-msvc
// maybe also test i686-pc-windows-gnu?
#![feature(no_core, rustc_attrs, lang_items)]
#![no_core]
#![crate_type = "lib"]

#[link(name = "foo", kind = "raw-dylib", import_name_type = 6)]
//~^ ERROR import name type must be of the form `import_name_type = "string"`
extern "C" {}

Unfortunately no_core is needed because otherwise it complains about not having std available.

JonathanBrouwer · 2025-08-26T13:32:06Z

@ChrisDenton I followed your trick (thanks a lot!) and I think I have all tests working now, but I didn't verify on a windows VM since after an hour of trying to get it working I still can't build the rust project using it, no clue why, getting weird errors and everything is super slow for some reason

@jdonszelmann Could you do a try run of @bors try jobs=i686-msvc-1,i686-msvc-2,aarch64-msvc-1,aarch64-msvc-2

jdonszelmann · 2025-08-26T15:36:40Z

@bors try jobs=i686-msvc-1,i686-msvc-2,aarch64-msvc-1,aarch64-msvc-2

Port `#[link]` to the new attribute parsing infrastructure try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: aarch64-msvc-1 try-job: aarch64-msvc-2

rust-bors · 2025-08-26T18:39:30Z

☀️ Try build successful (CI)
Build commit: c6a57b6 (c6a57b68f09c4ac5f467f06828ec440b93620413, parent: 5ab69249f36678c0a770a08d3d1b28a8103349ff)

bors · 2025-08-27T01:58:40Z

☔ The latest upstream changes (presumably #145906) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Jonathan Brouwer <[email protected]>

rustbot · 2025-08-27T18:32:35Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 29, 2025

JonathanBrouwer force-pushed the link_rework branch from 47c45bb to aaf7d53 Compare June 29, 2025 13:36

This comment has been minimized.

Sign in to view

jdonszelmann mentioned this pull request Jul 3, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

JonathanBrouwer force-pushed the link_rework branch from aaf7d53 to d43b4b5 Compare July 15, 2025 20:19

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jul 15, 2025

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the link_rework branch 6 times, most recently from 29b3648 to 6b10a20 Compare July 16, 2025 11:47

JonathanBrouwer commented Jul 16, 2025

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 16, 2025

rustbot assigned jdonszelmann Jul 16, 2025

JonathanBrouwer marked this pull request as ready for review July 16, 2025 12:25

JonathanBrouwer mentioned this pull request Aug 25, 2025

Improve error messages around invalid literals in attribute arguments #145853

Draft

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2025

jhpratt mentioned this pull request Aug 25, 2025

Rollup of 12 pull requests #145860

Closed

Zalathar mentioned this pull request Aug 26, 2025

Rollup of 13 pull requests #145865

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2025

JonathanBrouwer force-pushed the link_rework branch from ff053ba to 9cbd0c7 Compare August 26, 2025 13:27

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 26, 2025

Auto merge of #143193 - JonathanBrouwer:link_rework, r=<try>

c6a57b6

Port `#[link]` to the new attribute parsing infrastructure try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: aarch64-msvc-1 try-job: aarch64-msvc-2

JonathanBrouwer added 3 commits August 27, 2025 20:24

Move NativeLibKind from rustc_session to rustc_hir

aab5e0b

Port the #[link] attribute to the new parser

e8d08b5

Changes to the uitests

7db1840

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the link_rework branch from 9cbd0c7 to 7db1840 Compare August 27, 2025 18:32


		#[link(name = "bar", import_name_type = "decorated", kind = "raw-dylib")]
		#[link(name = "bar", kind = "raw-dylib")]

Port #[link] to the new attribute parsing infrastructure #143193

Are you sure you want to change the base?

Port #[link] to the new attribute parsing infrastructure #143193

Conversation

JonathanBrouwer commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Jun 30, 2025

Uh oh!

This comment has been minimized.

JonathanBrouwer Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Jul 16, 2025

Uh oh!

rustbot commented Jul 16, 2025

Uh oh!

rustbot commented Jul 16, 2025

Uh oh!

jdonszelmann commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

jdonszelmann commented Jul 16, 2025

Uh oh!

craterbot commented Jul 16, 2025

Uh oh!

jdonszelmann commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Zalathar commented Aug 26, 2025

Uh oh!

jdonszelmann commented Aug 26, 2025

Uh oh!

ChrisDenton commented Aug 26, 2025

Uh oh!

JonathanBrouwer commented Aug 26, 2025

Uh oh!

ChrisDenton commented Aug 26, 2025

Uh oh!

JonathanBrouwer commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Aug 26, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 26, 2025

Uh oh!

bors commented Aug 27, 2025

Uh oh!

rustbot commented Aug 27, 2025

Uh oh!

Uh oh!

Port `#[link]` to the new attribute parsing infrastructure #143193

Port `#[link]` to the new attribute parsing infrastructure #143193

JonathanBrouwer commented Jun 29, 2025 •

edited

Loading

JonathanBrouwer commented Aug 26, 2025 •

edited

Loading