Skip to content

Conversation

lukas-code
Copy link
Member

implements #112366 (comment)

No functional changes.

Best reviewed with whitespace diff disabled.

r? @Nilstrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2023
@Noratrieb
Copy link
Member

oops, i forgot about this
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 24, 2023

📌 Commit d50875e has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2023
@bors
Copy link
Collaborator

bors commented Jun 24, 2023

⌛ Testing commit d50875e with merge 13e785bbc0e6b9014f7df5b18d14bca8a7c0bdab...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
      System Firmware Version: VMW71.00V.13989454.B64.1906190538
      OS Loader Version: 540.120.3~22
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMB4P8qMIPMY
      Provisioning UDID: 4203018E-580F-C1B5-9525-B745CECA79EB

hw.ncpu: 3
hw.byteorder: 1234
---
extracting /Users/runner/work/rust/rust/build/cache/2023-05-30/cargo-beta-x86_64-unknown-linux-gnu.tar.xz to /Users/runner/work/rust/rust/build/x86_64-unknown-linux-gnu/stage0
downloading https://static.rust-lang.org/dist/2023-05-30/rust-std-beta-aarch64-apple-darwin.tar.xz
extracting /Users/runner/work/rust/rust/build/cache/2023-05-30/rust-std-beta-aarch64-apple-darwin.tar.xz to /Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage0
downloading https://static.rust-lang.org/dist/2023-05-30/rustc-beta-aarch64-apple-darwin.tar.xz
thread 'config::tests::download_ci_llvm' panicked at 'status code: 1', /Users/runner/work/rust/rust/src/tools/build_helper/src/util.rs:16:9

failures:
    config::tests::download_ci_llvm

@bors
Copy link
Collaborator

bors commented Jun 24, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2023
@Noratrieb
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2023
@bors
Copy link
Collaborator

bors commented Jun 24, 2023

⌛ Testing commit d50875e with merge ed1ce58...

@bors
Copy link
Collaborator

bors commented Jun 24, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing ed1ce58 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 24, 2023
@bors bors merged commit ed1ce58 into rust-lang:master Jun 24, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 24, 2023
@lukas-code lukas-code deleted the fancy-bool branch June 24, 2023 14:24
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ed1ce58): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 661.562s -> 662.351s (0.12%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants