#[test] function signature verification improvements
#112366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 6, 2023 23:28
Previously, these were allowed if the function returned `()`, but always led to an ambiguity error.
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
lukas-code
commented
Jun 6, 2023
| } | ||
| (false, _) => true, | ||
| if has_should_panic_attr && has_output { | ||
| sd.span_err(i.span, "functions using `#[should_panic]` must return `()`"); |
There was a problem hiding this comment.
Noratrieb
reviewed
Jun 19, 2023
| (false, _) => true, | ||
| if has_should_panic_attr && has_output { | ||
| sd.span_err(i.span, "functions using `#[should_panic]` must return `()`"); | ||
| return false; |
There was a problem hiding this comment.
this function should probably return Result<(), ErrorGuaranteed> in a follow-up PR if you want
Noratrieb
approved these changes
Jun 19, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Jun 19, 2023
`#[test]` function signature verification improvements This PR contains two improvements to the expansion of the `#[test]` macro. The first one fixes rust-lang#112360 by correctly recovering item statements if the signature verification fails. The second one forbids non-lifetime generics on `#[test]` functions. These were previously allowed if the function returned `()`, but always caused an inference error: before: ```text error[E0282]: type annotations needed --> src/lib.rs:2:1 | 1 | #[test] | ------- in this procedural macro expansion 2 | fn foo<T>() {} | ^^^^^^^^^^^^^^ cannot infer type ``` after: ```text error: functions used as tests can not have any non-lifetime generic parameters --> src/lib.rs:2:1 | 2 | fn foo<T>() {} | ^^^^^^^^^^^^^^ ``` Also includes some basic tests for test function signature verification, because I couldn't find any (???) in the test suite.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (6895110): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 658.179s -> 656.783s (-0.21%) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2023
use ErrorGuaranteed instead of booleans in rustc_builtin_macros implements rust-lang#112366 (comment) No functional changes. Best reviewed with whitespace diff disabled. r? `@Nilstrieb`
oli-obk
pushed a commit
to oli-obk/miri
that referenced
this pull request
Jun 28, 2023
use ErrorGuaranteed instead of booleans in rustc_builtin_macros implements rust-lang/rust#112366 (comment) No functional changes. Best reviewed with whitespace diff disabled. r? `@Nilstrieb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two improvements to the expansion of the
#[test]macro.The first one fixes #112360 by correctly recovering item statements if the signature verification fails.
The second one forbids non-lifetime generics on
#[test]functions. These were previously allowed if the function returned(), but always caused an inference error:before:
after:
Also includes some basic tests for test function signature verification, because I couldn't find any (???) in the test suite.