Skip to content

Conversation

petrochenkov
Copy link
Contributor

Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
Noticed while reviewing #108729.

Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2023
@petrochenkov
Copy link
Contributor Author

@bors rollup

@WaffleLapkin
Copy link
Member

r? @WaffleLapkin
@bors r+

@bors
Copy link
Collaborator

bors commented Mar 17, 2023

📌 Commit 2a52080 has been approved by WaffleLapkin

It is now in the queue for this repository.

@rustbot rustbot assigned WaffleLapkin and unassigned TaKO8Ki Mar 17, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
resolve: Improve debug impls for `NameBinding`

Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
Noticed while reviewing rust-lang#108729.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
resolve: Improve debug impls for `NameBinding`

Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
Noticed while reviewing rust-lang#108729.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
resolve: Improve debug impls for `NameBinding`

Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
Noticed while reviewing rust-lang#108729.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#109102 (Erase escaping late-bound regions when probing for ambiguous associated types)
 - rust-lang#109200 (Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer`)
 - rust-lang#109211 (E0206 - update description )
 - rust-lang#109222 (Do not ICE for unexpected lifetime with ConstGeneric rib)
 - rust-lang#109235 (fallback to lstat when stat fails on Windows)
 - rust-lang#109248 (Pass the right HIR back from `get_fn_decl`)
 - rust-lang#109251 (Suggest surrounding the macro with `{}` to interpret as a statement)
 - rust-lang#109256 (Check for llvm-tools before install)
 - rust-lang#109257 (resolve: Improve debug impls for `NameBinding`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0d4a56c into rust-lang:master Mar 18, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 18, 2023
@petrochenkov petrochenkov deleted the bindebug branch February 22, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants