Skip to content

Erase escaping late-bound regions when probing for ambiguous associated types #109102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2023
Merged

Erase escaping late-bound regions when probing for ambiguous associated types #109102

merged 1 commit into from
Mar 18, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #109090

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 13, 2023
compiler-errors
compiler-errors commented Mar 13, 2023
View reviewed changes
compiler/rustc_hir_analysis/src/astconv/mod.rs
@@ -2395,13 +2395,22 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
tcx,
infcx.fresh_substs_for_item(DUMMY_SP, impl_def_id),
);
let universe = infcx.create_next_universe();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need to make a universe unless we need it, but also we're on the error path, so it doesn't matter here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this as a comment

davidtwco
davidtwco approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but someone else should take a look.

@davidtwco
Copy link
Member

r? rust-lang/types

@rustbot rustbot assigned jackh726 and unassigned davidtwco Mar 16, 2023
jackh726
jackh726 requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment

compiler/rustc_hir_analysis/src/astconv/mod.rs
@@ -2395,13 +2395,22 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
tcx,
infcx.fresh_substs_for_item(DUMMY_SP, impl_def_id),
);
let universe = infcx.create_next_universe();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this as a comment

@compiler-errors compiler-errors force-pushed the ambig-assoc-in-non-lt-binder branch from 559a980 to 79ad7cc Compare March 17, 2023 15:33
@compiler-errors
Copy link
Member Author

@bors r=jackh726 rollup (diagnostics only)

@bors
Copy link
Collaborator

bors commented Mar 17, 2023

📌 Commit 79ad7cc has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#109102 - compiler-errors:ambig-assoc-in-non…
a558adf 
…-lt-binder, r=jackh726

Erase escaping late-bound regions when probing for ambiguous associated types

Fixes rust-lang#109090
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#109102 - compiler-errors:ambig-assoc-in-non…
38baf89 
…-lt-binder, r=jackh726

Erase escaping late-bound regions when probing for ambiguous associated types

Fixes rust-lang#109090
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#109102 - compiler-errors:ambig-assoc-in-non…
62ae485 
…-lt-binder, r=jackh726

Erase escaping late-bound regions when probing for ambiguous associated types

Fixes rust-lang#109090
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2023
@bors
Auto merge of rust-lang#109284 - matthiaskrgr:rollup-aaublsx, r=matth…
85123d2 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#109102 (Erase escaping late-bound regions when probing for ambiguous associated types)
 - rust-lang#109200 (Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer`)
 - rust-lang#109211 (E0206 - update description )
 - rust-lang#109222 (Do not ICE for unexpected lifetime with ConstGeneric rib)
 - rust-lang#109235 (fallback to lstat when stat fails on Windows)
 - rust-lang#109248 (Pass the right HIR back from `get_fn_decl`)
 - rust-lang#109251 (Suggest surrounding the macro with `{}` to interpret as a statement)
 - rust-lang#109256 (Check for llvm-tools before install)
 - rust-lang#109257 (resolve: Improve debug impls for `NameBinding`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0ee7539 into rust-lang:master Mar 18, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 18, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 11, 2023
Closed
@compiler-errors compiler-errors deleted the ambig-assoc-in-non-lt-binder branch August 11, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 requested changes

@davidtwco davidtwco davidtwco approved these changes

Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

ICE: bound types encountered in super_relate_tys
5 participants
@compiler-errors @rustbot @davidtwco @bors @jackh726