Formatting lints for =@ and else ifs
#720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `@` in {`*`, `!`, `-`}.
| } | ||
|
|
||
| fn constant_not(o: Constant) -> Option<Constant> { | ||
| use syntax::ast::LitIntType::*; |
llogiq
added a commit
that referenced
this pull request
Feb 27, 2016
Formatting lints for `=@` and `else if`s
|
That was fast. 😄 @mcarton I'd like to have you writing some more challenging lints and leave the easy ones to new contributors. OK? |
|
There are plenty of easy lints left, I won’t implement them all, promised 😜. |
|
😄 OK then. |
|
Yeah, I was considering doing a sweep of a bunch of easy bugs too. It's good to have them, but 100+ open issues isn't too great :) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 4, 2025
This has always been one lint (added in #720), but the two cases are also quite distinct. changelog: Split `possible_missing_else` from `suspicious_else_formatting` <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - [Feature-freeze](#15317 (comment)) by [github-actions[bot]](https://github.com/github-actions[bot]) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details* <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #649. Fix #718.