Skip to content

Split possible_missing_else from suspicious_else_formatting #15317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Split possible_missing_else from suspicious_else_formatting #15317

merged 1 commit into from
Aug 4, 2025

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 20, 2025 •
edited by rustbot
Loading

This has always been one lint (added in #720), but the two cases are also quite distinct.

changelog: Split possible_missing_else from suspicious_else_formatting

Summary Notes

Managed by @rustbot—see help for details

@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2025 •
edited
Loading

No changes for 9e50049

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work A-lint Area: New lints and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 20, 2025
@Jarcho Jarcho mentioned this pull request Jul 20, 2025
Open
samueltardieu
samueltardieu approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be merged as-is. Even if this creates a new lint, it doesn't add any new functionality, so it is still in the spirit of the feature freeze and cleans things up.

blyxyas
blyxyas approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking Samuel's approval as the necessary one for the FCP. In the case that this needed an FCP. Also, I think we asked Philipp about this and he didn't have any hard feelings.

@blyxyas blyxyas removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Aug 4, 2025
@blyxyas blyxyas added this pull request to the merge queue Aug 4, 2025
Merged via the queue into rust-lang:master with commit 264bc97 Aug 4, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
A-lint Area: New lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jarcho @rustbot @samueltardieu @blyxyas