Add a new lint for comparison chains #4569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Sep 24, 2019
oli-obk
reviewed
Sep 24, 2019
There was a problem hiding this comment.
Awesome, thanks for working on this.
While I think this could be merged as is, it is also possible to emit a machine applicable suggestion. If you'd like to do that, too, we can either merge the PR and you open a new one adding the suggestion, or you can add it to this PR, whatever you prefer.
|
@oli-obk Actually I think I'd be more comfortable with merging the branch as it is right now then opening another PR with the machine applicable suggestion in the future. |
|
@bors r+ |
|
📌 Commit 2f34576 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 25, 2019
Add a new lint for comparison chains changelog: Adds a new lint: `comparison_chain`. `comparison_chain` lints all `if` conditional chains where all the conditions are binary comparisons on the same two operands and will suggest a rewrite with `match`. Closes #4531.
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Sep 26, 2019
Add a new lint for comparison chains changelog: Adds a new lint: `comparison_chain`. `comparison_chain` lints all `if` conditional chains where all the conditions are binary comparisons on the same two operands and will suggest a rewrite with `match`. Closes #4531.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Adds a new lint:
comparison_chain.comparison_chainlints allifconditional chains where all the conditions are binary comparisons on the same two operands and will suggest a rewrite withmatch.Closes #4531.