Add lint for use of ^ operator as exponentiation. #4541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #4511) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #4569) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased and force-pushed again to bring inline with upstream. |
jfrimmel
reviewed
Oct 6, 2019
| if let LitKind::Int(rhs, _) = lit.node; | ||
| then { | ||
| if lhs == 2 { | ||
| if rhs == 8 || rhs == 16 || rhs == 32 || rhs == 64 { |
|
☔ The latest upstream changes (presumably #4592) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks for contributing to Clippy! Sadly this PR was not updated in quite some time. If you waited on input from a reviewer, we're sorry that this fell under the radar. If you want to continue to work on this, just reopen the PR and/or ping a reviewer. |
flip1995
added
S-inactive-closed
|
I'd like to pick this up and pull it over the finish line, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opens and updates the closed PR to add this new lint.
Incorporated review feedback from previous PR and added functionality around
.pow()andstd::_::MAX. Also tried to cleanup the messages to be more user friendly.Fixes #4205
changelog: Add lint for using xor operator when exponentiation was intended.