Skip to content

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Aug 30, 2023

This makes ui_test parse --bless and allows a follow up change to use Mode::Error (instead of Mode::Yolo) with RustfixMode::Everything

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 30, 2023
@flip1995
Copy link
Member

r? @Alexendoo Since you are always the one that has to revert ui_test changes when I'm over-eager in merging them. Let's change that.

@rustbot rustbot assigned Alexendoo and unassigned Jarcho Aug 30, 2023
@Alexendoo
Copy link
Member

Opened oli-obk/ui_test#157 to get OutputConflictHandling::Error back, particularly for the internal tests where the command is difficult to remember

@Alexendoo
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit aeed86c has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 1, 2023

⌛ Testing commit aeed86c with merge acdffd7...

@bors
Copy link
Contributor

bors commented Sep 1, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing acdffd7 to master...

@bors bors merged commit acdffd7 into rust-lang:master Sep 1, 2023
@oli-obk oli-obk deleted the ui_test_bump branch September 1, 2023 12:28
smoelius added a commit to trailofbits/dylint that referenced this pull request Sep 1, 2023
smoelius added a commit to trailofbits/dylint that referenced this pull request Sep 1, 2023
smoelius added a commit to trailofbits/dylint that referenced this pull request Sep 1, 2023
smoelius added a commit to trailofbits/dylint that referenced this pull request Sep 7, 2023
smoelius added a commit to trailofbits/dylint that referenced this pull request Sep 13, 2023
github-merge-queue bot pushed a commit to trailofbits/dylint that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants