Populate Config with Args instead of passing it to run_tests_generic
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexendoo
force-pushed
the
args-to-config
branch
from
8cf4964 to
5ece6ea
Compare
oli-obk
reviewed
Aug 31, 2023
Owner
|
Please also do a major version bump in this PR. |
Alexendoo
force-pushed
the
args-to-config
branch
from
5ece6ea to
38c018f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argsnow solely parses arguments and is used to fill in fields onConfig, the default number of test threads is also moved intorun_tests_genericThis reintroduces
OutputConflictHandlingas the command string in the error variant is nice to have