Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 17, 2020

If there was an error exec-ing a process with cargo run, the error message was not displayed. The code was calling downcast to a ProcessError which erased the surrounding error context. As shown in the modified test, it should now include a Caused by: message with the underlying error message.

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2020
@Eh2406
Copy link
Contributor

Eh2406 commented Aug 17, 2020

Looks reasonable to me.

@alexcrichton
Copy link
Member

@bors: r=Eh2406

@bors
Copy link
Contributor

bors commented Aug 18, 2020

📌 Commit 18bc90c has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2020
@bors
Copy link
Contributor

bors commented Aug 18, 2020

⌛ Testing commit 18bc90c with merge e0dfa08...

@bors
Copy link
Contributor

bors commented Aug 18, 2020

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing e0dfa08 to master...

@bors bors merged commit e0dfa08 into rust-lang:master Aug 18, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2020
Update cargo

5 commits in ab32ee88dade1b50c77347599e82ca2de3fb8a51..51b66125ba97d2906f461b3f4e0408f206299bb6
2020-08-10 17:44:43 +0000 to 2020-08-19 20:22:52 +0000
- Add chapters on dependency resolution and SemVer compatibility. (rust-lang/cargo#8609)
- Renames SourceId::into_url -> SourceId::as_url (rust-lang/cargo#8611)
- Fix bug with PathAndArg config values (rust-lang/cargo#8629)
- Show full error context on `cargo run` error. (rust-lang/cargo#8627)
- Fix typo in SIGQUIT description (rust-lang/cargo#8615)
@ehuss ehuss added this to the 1.47.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants