Renames SourceId::into_url -> SourceId::as_url #8611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While studying the source code, I am surprised to see that `into_url` does not actually consume the string when a function with such name usually does. Additionally, there are traits in `cargo::util::IntoUrl` with the same and does exactly what you expect, consumes T and yields a `Url`. I hope this is not too nitpicky. Thank you!
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Thanks! Maybe the struct |
Contributor
|
Thanks! |
Contributor
|
📌 Commit 3dbac42 has been approved by |
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2020
Update cargo 5 commits in ab32ee88dade1b50c77347599e82ca2de3fb8a51..51b66125ba97d2906f461b3f4e0408f206299bb6 2020-08-10 17:44:43 +0000 to 2020-08-19 20:22:52 +0000 - Add chapters on dependency resolution and SemVer compatibility. (rust-lang/cargo#8609) - Renames SourceId::into_url -> SourceId::as_url (rust-lang/cargo#8611) - Fix bug with PathAndArg config values (rust-lang/cargo#8629) - Show full error context on `cargo run` error. (rust-lang/cargo#8627) - Fix typo in SIGQUIT description (rust-lang/cargo#8615)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While studying the source code, I am surprised to see that
into_urldoes not actually consume its caller when a function with such name
usually does. Additionally, there is a trait in
cargo::util::IntoUrlwith the same and does exactly what you expect, consumes itself and yields
a
CargoResult<Url>.I hope this is not too nitpicky.
Thank you!