-
Notifications
You must be signed in to change notification settings - Fork 122
Use provided selector for hint #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll merge the change asap, thanks for the PR |
👍 |
running-coder
added a commit
that referenced
this pull request
Nov 27, 2015
Use provided selector for hint
running-coder
added a commit
that referenced
this pull request
Dec 24, 2015
Features - Added option ``backdropOnFocus`` will trigger the backdrop option as long as the Typeahead input is focused - Added ``onShowLayout`` and ``onHideLayout`` callbacks - ``template`` can now be a function (query, item) that returns a template string - Added query string sanitization - Added ``.typeahead-item`` and ``.typeahead-empty`` on list items to easily apply CSS on these LI elements - #109 ``correlativeTemplate`` can be an array of display keys instead of the complete template - #111, #127 Added ``filter`` and ``matcher`` options. See the documentation to know the differences and possible return options. - #115 Added ``e.preventInputChange`` boolean to ``onNavigateBefore`` callback to prevent the input from changing when navigating (arrow up / down) the results - #118 Every functions and callbacks are now scoped with the Typeahead object, it is possible to use ``this`` to reach the Typeahead variables & functions - #122 It is now possible to set a custom accent object with ``from`` and ``to`` - #125 Added ``onNavigateAfter`` callback - #127 ``emptyTemplate`` now accepts a jQuery LI object - #132 It is now possible to set a function that returns a request object inside ``source.group.url`` Fixes - Removed ``.show()`` and ``.hide()`` jQuery functions, use the CSS instead! - Fixed dropdownFilter when clicking outside wouldn't close it - Fixed jQuery-3.0.0-alpha1 issue, missing the node.selector so using ``options.input`` is now mandatory for using Typeahead['#my-search'] (see extras section in documentation) - Fixed highlight option when query was empty - #121 ``selector.hint`` was not being interpreted
running-coder
added a commit
that referenced
this pull request
Dec 24, 2015
Features - Added option ``backdropOnFocus`` will trigger the backdrop option as long as the Typeahead input is focused - Added ``onShowLayout`` and ``onHideLayout`` callbacks - ``template`` can now be a function (query, item) that returns a template string - Added query string sanitization - Added ``.typeahead-item`` and ``.typeahead-empty`` on list items to easily apply CSS on these LI elements - #109 ``correlativeTemplate`` can be an array of display keys instead of the complete template - #111, #127 Added ``filter`` and ``matcher`` options. See the documentation to know the differences and possible return options. - #115 Added ``e.preventInputChange`` boolean to ``onNavigateBefore`` callback to prevent the input from changing when navigating (arrow up / down) the results - #118 Every functions and callbacks are now scoped with the Typeahead object, it is possible to use ``this`` to reach the Typeahead variables & functions - #122 It is now possible to set a custom accent object with ``from`` and ``to`` - #125 Added ``onNavigateAfter`` callback - #127 ``emptyTemplate`` now accepts a jQuery LI object - #132 It is now possible to set a function that returns a request object inside ``source.group.url`` Fixes - Removed ``.show()`` and ``.hide()`` jQuery functions, use the CSS instead! - Fixed dropdownFilter when clicking outside wouldn't close it - Fixed jQuery-3.0.0-alpha1 issue, missing the node.selector so using ``options.input`` is now mandatory for using Typeahead['#my-search'] (see extras section in documentation) - Fixed highlight option when query was empty - #121 ``selector.hint`` was not being interpreted
running-coder
added a commit
that referenced
this pull request
Dec 24, 2015
Features - Added option ``backdropOnFocus`` will trigger the backdrop option as long as the Typeahead input is focused - Added ``onShowLayout`` and ``onHideLayout`` callbacks - ``template`` can now be a function (query, item) that returns a template string - Added query string sanitization - Added ``.typeahead-item`` and ``.typeahead-empty`` on list items to easily apply CSS on these LI elements - #109 ``correlativeTemplate`` can be an array of display keys instead of the complete template - #111, #127 Added ``filter`` and ``matcher`` options. See the documentation to know the differences and possible return options. - #115 Added ``e.preventInputChange`` boolean to ``onNavigateBefore`` callback to prevent the input from changing when navigating (arrow up / down) the results - #118 Every functions and callbacks are now scoped with the Typeahead object, it is possible to use ``this`` to reach the Typeahead variables & functions - #122 It is now possible to set a custom accent object with ``from`` and ``to`` - #125 Added ``onNavigateAfter`` callback - #127 ``emptyTemplate`` now accepts a jQuery LI object - #132 It is now possible to set a function that returns a request object inside ``source.group.url`` Fixes - Removed ``.show()`` and ``.hide()`` jQuery functions, use the CSS instead! - Fixed dropdownFilter when clicking outside wouldn't close it - Fixed jQuery-3.0.0-alpha1 issue, missing the node.selector so using ``options.input`` is now mandatory for using Typeahead['#my-search'] (see extras section in documentation) - Fixed highlight option when query was empty - #121 ``selector.hint`` was not being interpreted
running-coder
added a commit
that referenced
this pull request
Dec 26, 2015
Features - Added option ``backdropOnFocus`` will trigger the backdrop option as long as the Typeahead input is focused - Added ``onShowLayout`` and ``onHideLayout`` callbacks - ``template`` can now be a function (query, item) that returns a template string - Added query string sanitization - Added ``.typeahead-item`` and ``.typeahead-empty`` on list items to easily apply CSS on these LI elements - Added a resetLayout function - #109 ``correlativeTemplate`` can be an array of display keys instead of the complete template - #111, #127 Added ``filter`` and ``matcher`` options. See the documentation to know the differences and possible return options. - #115 Added ``e.preventInputChange`` boolean to ``onNavigateBefore`` callback to prevent the input from changing when navigating (arrow up / down) the results - #118 Every functions and callbacks are now scoped with the Typeahead object, it is possible to use ``this`` to reach the Typeahead variables & functions - #122 It is now possible to set a custom accent object with ``from`` and ``to`` - #125 Added ``onNavigateAfter`` callback - #127 ``emptyTemplate`` now accepts a jQuery LI object - #132 It is now possible to set a function that returns a request object inside ``source.group.url`` Fixes - Removed ``.show()`` and ``.hide()`` jQuery functions, use the CSS instead! - Fixed dropdownFilter when clicking outside wouldn't close it - Fixed jQuery-3.0.0-alpha1 issue, missing the node.selector so using ``options.input`` is now mandatory for using Typeahead['#my-search'] (see extras section in documentation) - Fixed highlight option when query was empty - Fixed href option where clicking the "a" link wouldn't redirect - Fixed group search - #121 ``selector.hint`` was not being interpreted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was always using
typeahead-hint
.